Migrate ArchiveNotifier from UNSAFE_componentWillReceiveProps #614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #614 +/- ##
==========================================
+ Coverage 92.79% 92.80% +0.01%
==========================================
Files 227 227
Lines 5911 5910 -1
Branches 1491 1490 -1
==========================================
Hits 5485 5485
+ Misses 385 384 -1
Partials 41 41
Continue to review full report at Codecov.
|
…erivedStateFromProps Signed-off-by: Tim Klever <Tim.V.Klever@aexp.com>
tklever
force-pushed
the
refactor-UNSAFE-componentWillRecieveProps-archivenotifier
branch
from
d2a40f5
to
3488148
Compare
|
LGTM |
yurishkuro
approved these changes
Aug 15, 2020
yurishkuro
changed the title
|
thanks! |
tklever
deleted the
refactor-UNSAFE-componentWillRecieveProps-archivenotifier
branch
vvvprabhakar
pushed a commit
to vvvprabhakar/jaeger-ui
that referenced
this pull request
Jul 4, 2021
…tracing#614) Signed-off-by: Tim Klever <Tim.V.Klever@aexp.com> Signed-off-by: vvvprabhakar <vvvprabhakar@gmail.com>
vvvprabhakar
pushed a commit
to vvvprabhakar/jaeger-ui
that referenced
this pull request
Jul 4, 2021
…tracing#614) Signed-off-by: Tim Klever <Tim.V.Klever@aexp.com> Signed-off-by: vvvprabhakar <vvvprabhakar@gmail.com>
vvvprabhakar
pushed a commit
to vvvprabhakar/jaeger-ui
that referenced
this pull request
Jul 5, 2021
…tracing#614) Signed-off-by: Tim Klever <Tim.V.Klever@aexp.com> Signed-off-by: vvvprabhakar <vvvprabhakar@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Short description of the changes