Additional Test Coverage around TimelineViewingLayer #617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In addition to rounding out the test suite, this commit also removes some of the "Math.random" calls from the test suite. These randoms were causing some code coverage jitter in the test suite by randomly executing certain code paths. Removing these randomizations will keep coverage reporting consistent and avoid random "coverage losses" based on chance. Signed-off-by: Tim Klever <Tim.V.Klever@aexp.com>
CreateRef API was introduced in React 16.3 Signed-off-by: Tim Klever <Tim.V.Klever@aexp.com>
Codecov Report
@@ Coverage Diff @@
## master #617 +/- ##
==========================================
+ Coverage 93.44% 93.54% +0.10%
==========================================
Files 227 227
Lines 5902 5901 -1
Branches 1486 1485 -1
==========================================
+ Hits 5515 5520 +5
+ Misses 346 340 -6
Partials 41 41
Continue to review full report at Codecov.
|
|
@rubenvp8510 please make sure PRs (and, respectively, merged commits) have the title that satisfies "good commit message" criteria (see https://github.com/jaegertracing/jaeger-ui/blob/master/CONTRIBUTING.md#making-a-change) |
vvvprabhakar
pushed a commit
to vvvprabhakar/jaeger-ui
that referenced
this pull request
Jul 4, 2021
* add additional tests around existing TimelineViewingLayer functionality In addition to rounding out the test suite, this commit also removes some of the "Math.random" calls from the test suite. These randoms were causing some code coverage jitter in the test suite by randomly executing certain code paths. Removing these randomizations will keep coverage reporting consistent and avoid random "coverage losses" based on chance. Signed-off-by: Tim Klever <Tim.V.Klever@aexp.com> * migrate from callback ref to CreateRef in TimelineViewingLayer CreateRef API was introduced in React 16.3 Signed-off-by: Tim Klever <Tim.V.Klever@aexp.com> Co-authored-by: Ruben Vargas Palma <ruben.vp8510@gmail.com> Signed-off-by: vvvprabhakar <vvvprabhakar@gmail.com>
vvvprabhakar
pushed a commit
to vvvprabhakar/jaeger-ui
that referenced
this pull request
Jul 4, 2021
* add additional tests around existing TimelineViewingLayer functionality In addition to rounding out the test suite, this commit also removes some of the "Math.random" calls from the test suite. These randoms were causing some code coverage jitter in the test suite by randomly executing certain code paths. Removing these randomizations will keep coverage reporting consistent and avoid random "coverage losses" based on chance. Signed-off-by: Tim Klever <Tim.V.Klever@aexp.com> * migrate from callback ref to CreateRef in TimelineViewingLayer CreateRef API was introduced in React 16.3 Signed-off-by: Tim Klever <Tim.V.Klever@aexp.com> Co-authored-by: Ruben Vargas Palma <ruben.vp8510@gmail.com> Signed-off-by: vvvprabhakar <vvvprabhakar@gmail.com>
vvvprabhakar
pushed a commit
to vvvprabhakar/jaeger-ui
that referenced
this pull request
Jul 5, 2021
* add additional tests around existing TimelineViewingLayer functionality In addition to rounding out the test suite, this commit also removes some of the "Math.random" calls from the test suite. These randoms were causing some code coverage jitter in the test suite by randomly executing certain code paths. Removing these randomizations will keep coverage reporting consistent and avoid random "coverage losses" based on chance. Signed-off-by: Tim Klever <Tim.V.Klever@aexp.com> * migrate from callback ref to CreateRef in TimelineViewingLayer CreateRef API was introduced in React 16.3 Signed-off-by: Tim Klever <Tim.V.Klever@aexp.com> Co-authored-by: Ruben Vargas Palma <ruben.vp8510@gmail.com> Signed-off-by: vvvprabhakar <vvvprabhakar@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Short description of the changes