Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding tests around existing ArchiveNotifier duck #622

Merged

Conversation

tklever
Copy link
Contributor

@tklever tklever commented Aug 23, 2020

Which problem is this PR solving?

  • Adding tests around existing ArchiveNotifier/duck code

Short description of the changes

  • Adding tests around ArchiveNotifier/duck
  • Updated a redux middleware to return next() (keeps redux promise chains intact)

Signed-off-by: Tim Klever <Tim.V.Klever@aexp.com>
@codecov
Copy link

codecov bot commented Aug 23, 2020

Codecov Report

Merging #622 into master will increase coverage by 0.37%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #622      +/-   ##
==========================================
+ Coverage   93.54%   93.91%   +0.37%     
==========================================
  Files         227      227              
  Lines        5901     5901              
  Branches     1485     1485              
==========================================
+ Hits         5520     5542      +22     
+ Misses        340      319      -21     
+ Partials       41       40       -1     
Impacted Files Coverage Δ
packages/jaeger-ui/src/middlewares/index.js 81.81% <100.00%> (+18.18%) ⬆️
packages/jaeger-ui/src/reducers/embedded.tsx 100.00% <0.00%> (+25.00%) ⬆️
packages/jaeger-ui/src/reducers/config.js 100.00% <0.00%> (+33.33%) ⬆️
packages/jaeger-ui/src/middlewares/track.tsx 75.00% <0.00%> (+37.50%) ⬆️
.../src/components/TracePage/ArchiveNotifier/duck.tsx 100.00% <0.00%> (+78.94%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6513b53...01d2076. Read the comment docs.

@yurishkuro
Copy link
Member

Thanks!

vvvprabhakar pushed a commit to vvvprabhakar/jaeger-ui that referenced this pull request Jul 4, 2021
Signed-off-by: Tim Klever <Tim.V.Klever@aexp.com>
Signed-off-by: vvvprabhakar <vvvprabhakar@gmail.com>
vvvprabhakar pushed a commit to vvvprabhakar/jaeger-ui that referenced this pull request Jul 4, 2021
Signed-off-by: Tim Klever <Tim.V.Klever@aexp.com>
Signed-off-by: vvvprabhakar <vvvprabhakar@gmail.com>
vvvprabhakar pushed a commit to vvvprabhakar/jaeger-ui that referenced this pull request Jul 5, 2021
Signed-off-by: Tim Klever <Tim.V.Klever@aexp.com>
Signed-off-by: vvvprabhakar <vvvprabhakar@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants