Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display references unless it's a single CHILD_OF #672

Merged
merged 3 commits into from
Dec 25, 2020
Merged

Display references unless it's a single CHILD_OF #672

merged 3 commits into from
Dec 25, 2020

Conversation

yurishkuro
Copy link
Member

@yurishkuro yurishkuro commented Dec 25, 2020 •
edited
Loading

Resolves #358

@yurishkuro
Display references unless it's a single CHILD_OF
affe5e0 
Signed-off-by: Yuri Shkuro <github@ysh.us>
@yurishkuro
Copy link
Member Author

Normal span with CHILD_OF
image

@yurishkuro
Copy link
Member Author

Same span with reference changed to FOLLOWS_FROM
image

@yurishkuro
Copy link
Member Author

same span with two references
image

@codecov
Copy link

codecov bot commented Dec 25, 2020 •
edited
Loading

Codecov Report

Merging #672 (ed0ca85) into master (1fe8c6d) will increase coverage by 0.01%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #672      +/-   ##
==========================================
+ Coverage   94.24%   94.26%   +0.01%     
==========================================
  Files         228      228              
  Lines        5930     5930              
  Branches     1448     1448              
==========================================
+ Hits         5589     5590       +1     
+ Misses        308      306       -2     
- Partials       33       34       +1
Impacted Files Coverage Δ
...TracePage/TraceTimelineViewer/SpanDetail/index.tsx 93.75% <50.00%> (-6.25%) ⬇️
...nents/TracePage/TraceTimelineViewer/SpanBarRow.tsx 79.31% <0.00%> (+6.89%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1fe8c6d...ed0ca85. Read the comment docs.

@yurishkuro yurishkuro marked this pull request as ready for review December 25, 2020 18:55
@yurishkuro
Display references unless it's a single CHILD_OF
c751cf0 
Signed-off-by: Yuri Shkuro <github@ysh.us>
@yurishkuro
Display references unless it's a single CHILD_OF
ed0ca85 
Signed-off-by: Yuri Shkuro <github@ysh.us>
@yurishkuro yurishkuro merged commit 551db4c into jaegertracing:master Dec 25, 2020
@yurishkuro yurishkuro deleted the references branch December 25, 2020 21:27
vvvprabhakar pushed a commit to vvvprabhakar/jaeger-ui that referenced this pull request Jul 4, 2021
@yurishkuro @vvvprabhakar
Display references unless it's a single CHILD_OF (jaegertracing#672)
cc00083 
Signed-off-by: vvvprabhakar <vvvprabhakar@gmail.com>
vvvprabhakar pushed a commit to vvvprabhakar/jaeger-ui that referenced this pull request Jul 4, 2021
@yurishkuro @vvvprabhakar
Display references unless it's a single CHILD_OF (jaegertracing#672)
41fd053 
Signed-off-by: vvvprabhakar <vvvprabhakar@gmail.com>
vvvprabhakar pushed a commit to vvvprabhakar/jaeger-ui that referenced this pull request Jul 5, 2021
@yurishkuro
Display references unless it's a single CHILD_OF (jaegertracing#672)
0536c8a 
Signed-off-by: vvvprabhakar <vvvprabhakar@gmail.com>
This was referenced Jul 30, 2021
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@everett980 everett980 Awaiting requested review from everett980

@rubenvp8510 rubenvp8510 Awaiting requested review from rubenvp8510

@tiffon tiffon Awaiting requested review from tiffon

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Include references in Span Details
1 participant
@yurishkuro