[feat]: add upload widget into the search form tab

[meenal06]

Which problem is this PR solving?

• fixes Improve Search box UI and UX  #683
• reference Improve Search box UI and UX  #683 (comment)

Short description of the changes

• Combined upload json and search form page into a single tab

Screenshot

[meenal06]

Hi @rubenvp8510 @jpkrohling , please review and see if it suits the use-case 😄

[codecov]

Codecov Report

Merging #730 (6824600) into master (b5dd6f9) will increase coverage by 0.03%.
The diff coverage is n/a.

❗ Current head 6824600 differs from pull request most recent head 124037a. Consider uploading reports for the commit 124037a to get more accurate results

@@            Coverage Diff             @@
##           master     #730      +/-   ##
==========================================
+ Coverage   94.39%   94.42%   +0.03%     
==========================================
  Files         230      230              
  Lines        5959     5958       -1     
  Branches     1448     1448              
==========================================
+ Hits         5625     5626       +1     
+ Misses        300      298       -2     
  Partials       34       34              

Impacted Files	Coverage Δ
...r-ui/src/components/SearchTracePage/FileLoader.tsx	100.00% <ø> (ø)
.../jaeger-ui/src/components/SearchTracePage/index.js	86.66% <ø> (ø)
...nents/TracePage/TraceTimelineViewer/SpanBarRow.tsx	79.31% <0.00%> (+6.89%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5dd6f9...124037a. Read the comment docs.

[yurishkuro]

I am not sure this is an improvement. Uploading a file to the UI is not the primary use case, and we're sacrificing a bunch of primary top-level real estate to it.

I think the main issue raised in #683 has been fixed, but changing upload from a separate tab to something else is not a priority imo.

[meenal06]

I am not sure this is an improvement. Uploading a file to the UI is not the primary use case, and we're sacrificing a bunch of primary top-level real estate to it.

I think the main issue raised in #683 has been fixed, but changing upload from a separate tab to something else is not a priority imo.

So is this enhancement not needed? Or do we need to replace the click to upload with the drag-drop region as originally requested 🤔

[yurishkuro]

I am curious to see what others think. The second tab never bothered me, and #683 was just one person's opinion (plus I think it was more on the side of compacting the search form, which was done, the upload change was mixed in but really is a separate ask).

[jpkrohling]

Uploading a file to the UI is not the primary use case, and we're sacrificing a bunch of primary top-level real estate to it.

Agree with this.

[rubenvp8510]

I am not sure this is an improvement. Uploading a file to the UI is not the primary use case, and we're sacrificing a bunch of primary top-level real estate to it.

I agree, this makes sense, +1

I think the main issue raised in #683 has been fixed, but changing upload from a separate tab to something else is not a priority imo.

In #683 search form compaction is an improvement, but I think we leave the upload in a separate tab, is something that I don't think is a big deal.

[meenal06]

So should I close this PR? Also, can this be added as an outreachy contribution or not 😕 ?

[yurishkuro]

Yes, let's close the PR.

@jpkrohling might be able to answer re outreachy qualification (I'm +1 to count it in).

[jpkrohling]

Sorry for missing this: of course it counts! The goal is not to get the most PRs merged but contribute to the project. Sometimes, it's getting a PR merged, other times it's bringing clarity in some way, like what happened here.

[meenal06]

Thanks @jpkrohling !