Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Add null check for span.logs in search/filter-spans #734

Merged
merged 2 commits into from
Apr 13, 2021

Conversation

achesin
Copy link
Contributor

@achesin achesin commented Apr 13, 2021

Which problem is this PR solving?

  • Hello! This is a small PR for a bug I found in on the Trace Page. In the Trace Page Search Bar when you type in something that does not correspond with a tag, the page crashes and goes all white. That is because there was nothing checking to make sure span.logs was populated.

Short description of the changes

  • I added a check to make sure span.logs is not equal to null and a corresponding test.

achesin and others added 2 commits April 12, 2021 16:51
Signed-off-by: Amanda Chesin <Amanda.Chesin1@aexp.com>
@codecov
Copy link

codecov bot commented Apr 13, 2021

Codecov Report

Merging #734 (91305e6) into master (ae758fa) will increase coverage by 0.03%.
The diff coverage is 100.00%.

❗ Current head 91305e6 differs from pull request most recent head 63c5d65. Consider uploading reports for the commit 63c5d65 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #734      +/-   ##
==========================================
+ Coverage   94.39%   94.42%   +0.03%     
==========================================
  Files         230      230              
  Lines        5959     5959              
  Branches     1448     1448              
==========================================
+ Hits         5625     5627       +2     
+ Misses        300      298       -2     
  Partials       34       34              
Impacted Files Coverage Δ
packages/jaeger-ui/src/utils/filter-spans.tsx 100.00% <100.00%> (ø)
...nents/TracePage/TraceTimelineViewer/SpanBarRow.tsx 79.31% <0.00%> (+6.89%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae758fa...63c5d65. Read the comment docs.

Copy link
Member

@yurishkuro yurishkuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@yurishkuro yurishkuro changed the title Filter spans- null check for span.logs [fix] Add null check for span.logs in search/filter-spans Apr 13, 2021
@yurishkuro yurishkuro merged commit 9c87e90 into jaegertracing:master Apr 13, 2021
vvvprabhakar pushed a commit to vvvprabhakar/jaeger-ui that referenced this pull request Jun 23, 2021
…ing#734)

Signed-off-by: Amanda Chesin <Amanda.Chesin1@aexp.com>
Signed-off-by: vvvprabhakar <vvvprabhakar@gmail.com>
vvvprabhakar pushed a commit to vvvprabhakar/jaeger-ui that referenced this pull request Jul 4, 2021
…ing#734)

Signed-off-by: Amanda Chesin <Amanda.Chesin1@aexp.com>
Signed-off-by: vvvprabhakar <vvvprabhakar@gmail.com>
vvvprabhakar pushed a commit to vvvprabhakar/jaeger-ui that referenced this pull request Jul 4, 2021
…ing#734)

Signed-off-by: Amanda Chesin <Amanda.Chesin1@aexp.com>
Signed-off-by: vvvprabhakar <vvvprabhakar@gmail.com>
vvvprabhakar pushed a commit to vvvprabhakar/jaeger-ui that referenced this pull request Jul 4, 2021
…ing#734)

Signed-off-by: Amanda Chesin <Amanda.Chesin1@aexp.com>
Signed-off-by: vvvprabhakar <vvvprabhakar@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants