Made favicon background transparent. #786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Max Taggart <max.taggart@healthcatalyst.com>
acksmaggart
requested review from
everett980,
rubenvp8510 and
tiffon
as code owners
yurishkuro
approved these changes
Jul 21, 2021
|
Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Not much of a problem, but the favicon image had a white background, this PR makes the background transparent.
Short description of the changes
Instead of a white background the favicon now has a transparent background, which is consistent with the recently-updated logo image at src/img/jaeger-logo.svg and consistent with most modern favicons.
I have tested the new image in Chrome locally. Let me know if there other other automated tests that should be updated.
Signed-off-by: Max Taggart max.taggart@healthcatalyst.com