Respect BASE_URL in Trace Tabular View #861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caizixian
requested review from
everett980,
rubenvp8510 and
tiffon
as code owners
Fix jaegertracing#847 Signed-off-by: Zixian Cai <2891235+caizixian@users.noreply.github.com>
|
Fixed linter errors |
yurishkuro
approved these changes
Jan 4, 2022
Codecov Report
@@ Coverage Diff @@
## main #861 +/- ##
==========================================
- Coverage 95.33% 95.26% -0.07%
==========================================
Files 240 240
Lines 7460 7460
Branches 1865 1865
==========================================
- Hits 7112 7107 -5
- Misses 342 347 +5
Partials 6 6
Continue to review full report at Codecov.
|
|
@yurishkuro the change in the test coverage is likely from the reformatting. Would you be able to manually merge it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #847
Calling
prefixUrlwhen populating the hyperlinks in the table.