Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce ratePer window #885

Merged
merged 1 commit into from
Feb 19, 2022
Merged

Conversation

albertteoh
Copy link
Contributor

Signed-off-by: albertteoh see.kwang.teoh@gmail.com

Which problem is this PR solving?

Short description of the changes

  • Reduces the ratePer window from 1hr to 10m, to reduce confusion when users run the ATM demo (at docker-compose/monitor/docker-compose.yaml).

Signed-off-by: albertteoh <see.kwang.teoh@gmail.com>
@albertteoh albertteoh changed the title Remove inline comments Reduce ratePer window Feb 19, 2022
@codecov
Copy link

codecov bot commented Feb 19, 2022

Codecov Report

Merging #885 (6b39922) into main (57a3869) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #885   +/-   ##
=======================================
  Coverage   95.26%   95.26%           
=======================================
  Files         240      240           
  Lines        7460     7460           
  Branches     1865     1865           
=======================================
  Hits         7107     7107           
  Misses        347      347           
  Partials        6        6           
Impacted Files Coverage Δ
...r-ui/src/components/Monitor/ServicesView/index.tsx 98.71% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 57a3869...6b39922. Read the comment docs.

@albertteoh albertteoh merged commit 5c613b4 into jaegertracing:main Feb 19, 2022
@albertteoh albertteoh deleted the reduce-rateper branch February 19, 2022 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Monitor Tab: Reduce ratePer window
2 participants