Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monitor Tab - The x-axis timeframe should be according to the selected timeframe #886

Merged
merged 6 commits into from
Feb 22, 2022

Conversation

nofar9792
Copy link
Contributor

@nofar9792 nofar9792 commented Feb 20, 2022

Resolves #882

Which problem is this PR solving?

x axis timeframe should be what the user chose in the dropdown

Short description of the changes

add xDomain in order to define it by the dropdown value and not automatically interpolates across the relevant domains of the data

before:

Screen.Recording.2022-02-15.at.17.37.56.mov

after:

Screen.Recording.2022-02-15.at.17.38.29.mov

nofar9792 added 3 commits January 30, 2022 13:11
Signed-off-by: nofar9792 <nofar.cohen@logz.io>
Signed-off-by: nofar9792 <nofar.cohen@logz.io>
Signed-off-by: nofar9792 <nofar.cohen@logz.io>
@nofar9792
Copy link
Contributor Author

@AlonMiz

Signed-off-by: nofar9792 <nofar.cohen@logz.io>
@nofar9792
Copy link
Contributor Author

@yurishkuro ?

@codecov
Copy link

codecov bot commented Feb 22, 2022

Codecov Report

Merging #886 (130c001) into main (676a90b) will increase coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #886      +/-   ##
==========================================
+ Coverage   95.29%   95.34%   +0.05%     
==========================================
  Files         240      240              
  Lines        7460     7462       +2     
  Branches     1865     1865              
==========================================
+ Hits         7109     7115       +6     
+ Misses        345      341       -4     
  Partials        6        6              
Impacted Files Coverage Δ
...c/components/Monitor/ServicesView/serviceGraph.tsx 98.07% <ø> (ø)
...r-ui/src/components/Monitor/ServicesView/index.tsx 98.75% <100.00%> (+0.03%) ⬆️
...nents/TracePage/TraceTimelineViewer/SpanBarRow.tsx 94.44% <0.00%> (-5.56%) ⬇️
...mponents/TracePage/TraceStatistics/tableValues.tsx 95.86% <0.00%> (+2.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 676a90b...130c001. Read the comment docs.

@yurishkuro yurishkuro merged commit 7348b1e into jaegertracing:main Feb 22, 2022
@nofar9792 nofar9792 deleted the fix-x-axis branch February 23, 2022 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Monitor Tab - The x-axis timeframe should be according to the selected timeframe
2 participants