Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monitor Tab - Error rate graph in operation table is always a straight line #909

Merged

Conversation

nofar9792
Copy link
Contributor

Signed-off-by: nofar9792 nofar.cohen@logz.io

Which problem is this PR solving?

Resolves #908

Short description of the changes

The values of this graph are between 0 to 1, but the yDomain is hardcode 1-100

before:
Screen Shot 2022-03-10 at 23 49 42

after:
Screen Shot 2022-03-10 at 23 49 28

Signed-off-by: nofar9792 <nofar.cohen@logz.io>
@codecov
Copy link

codecov bot commented Mar 10, 2022

Codecov Report

Merging #909 (7e15890) into main (6295907) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #909      +/-   ##
==========================================
+ Coverage   95.43%   95.45%   +0.01%     
==========================================
  Files         240      240              
  Lines        7497     7497              
  Branches     1870     1870              
==========================================
+ Hits         7155     7156       +1     
+ Misses        336      335       -1     
  Partials        6        6              
Impacted Files Coverage Δ
...r-ui/src/components/Monitor/ServicesView/index.tsx 97.02% <ø> (ø)
...mponents/TracePage/TraceStatistics/tableValues.tsx 97.93% <0.00%> (-0.35%) ⬇️
...nents/TracePage/TraceTimelineViewer/SpanBarRow.tsx 100.00% <0.00%> (+5.55%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6295907...7e15890. Read the comment docs.

@nofar9792 nofar9792 force-pushed the error-rate-graph-operation-table branch from daba91d to 7e15890 Compare March 10, 2022 22:51
@nofar9792 nofar9792 closed this Mar 10, 2022
@nofar9792 nofar9792 reopened this Mar 10, 2022
@albertteoh albertteoh merged commit d19b02f into jaegertracing:main Mar 14, 2022
@albertteoh
Copy link
Contributor

Thanks!

@nofar9792 nofar9792 deleted the error-rate-graph-operation-table branch March 14, 2022 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Monitor Tab - Error rate graph in operation table is always a straight line
2 participants