Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monitor Tab - Truncate request rate and P95 latency numbers to two decimal places #911

Merged
merged 4 commits into from
Mar 14, 2022

Conversation

nofar9792
Copy link
Contributor

Which problem is this PR solving?

Resolves #910

Short description of the changes

use formatValue to format all the values in the operation table.
convertTimeUnitToShortTerm - support microseconds

nofar9792 added 3 commits March 11, 2022 00:02
Signed-off-by: nofar9792 <nofar.cohen@logz.io>
Signed-off-by: nofar9792 <nofar.cohen@logz.io>
Signed-off-by: nofar9792 <nofar.cohen@logz.io>
@nofar9792 nofar9792 changed the title Error rate p95 morereable Monitor Tab - Truncate request rate and P95 latency numbers to two decimal places Mar 10, 2022
@codecov
Copy link

codecov bot commented Mar 10, 2022

Codecov Report

Merging #911 (0d9dfe7) into main (d19b02f) will increase coverage by 0.08%.
The diff coverage is 100.00%.

❗ Current head 0d9dfe7 differs from pull request most recent head bea831c. Consider uploading reports for the commit bea831c to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #911      +/-   ##
==========================================
+ Coverage   95.29%   95.37%   +0.08%     
==========================================
  Files         240      240              
  Lines        7497     7502       +5     
  Branches     1870     1871       +1     
==========================================
+ Hits         7144     7155      +11     
+ Misses        347      341       -6     
  Partials        6        6              
Impacted Files Coverage Δ
...nitor/ServicesView/operationDetailsTable/index.tsx 100.00% <100.00%> (ø)
packages/jaeger-ui/src/utils/date.tsx 94.73% <100.00%> (+0.07%) ⬆️
...mponents/TracePage/TraceStatistics/tableValues.tsx 95.86% <0.00%> (+2.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d19b02f...bea831c. Read the comment docs.

@nofar9792
Copy link
Contributor Author

@albertteoh @yurishkuro ?

@yurishkuro yurishkuro merged commit a9e575f into jaegertracing:main Mar 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Monitor Tab - Truncate request rate and P95 latency numbers to two decimal places
3 participants