Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add error icon to errored services in trace list view #927

Merged
merged 5 commits into from
Apr 13, 2022
Merged

Add error icon to errored services in trace list view #927

merged 5 commits into from
Apr 13, 2022

Commits on Apr 13, 2022

  1. Add error icon to services that contain a span with an error tag. Ref… 

    …actor existing constants to state.

Signed-off-by: Jono Yan <jonoy@canva.com>
    Jono Yan committed Apr 13, 2022
    Configuration menu
    Copy the full SHA
    c6cfefa View commit details
    Browse the repository at this point in the history

  2. revert trackTraceConversions 

    Signed-off-by: Jono Yan <jonoy@canva.com>
    Jono Yan committed Apr 13, 2022
    Configuration menu
    Copy the full SHA
    bc268f6 View commit details
    Browse the repository at this point in the history

  3. Fix import order 

    Signed-off-by: Jono Yan <jonoy@canva.com>
    Jono Yan committed Apr 13, 2022
    Configuration menu
    Copy the full SHA
    5afa09b View commit details
    Browse the repository at this point in the history

  4. Add error icon test to ResultItem.test.js 

    Signed-off-by: Jono Yan <jonoy@canva.com>
    Jono Yan committed Apr 13, 2022
    Configuration menu
    Copy the full SHA
    62d2370 View commit details
    Browse the repository at this point in the history

  5. Update constructor to have state. 

    Signed-off-by: Jono Yan <jonoy@canva.com>
    Jono Yan committed Apr 13, 2022
    Configuration menu
    Copy the full SHA
    43f8704 View commit details
    Browse the repository at this point in the history