Store preferred span name column width in localStorage #965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobrik
force-pushed
the
ivan/remember-width
branch
from
6c58cbf
to
607831c
Compare
yurishkuro
reviewed
Jun 24, 2022
packages/jaeger-ui/src/components/TracePage/TraceTimelineViewer/duck.tsx
Show resolved
Hide resolved
bobrik
force-pushed
the
ivan/remember-width
branch
from
607831c
to
eed3116
Compare
Different developers tend to look at different kinds of traces, meaning that they often prefer some set width of span name column in trace view. Without this patch, the width is set at 25% and it resets on refresh. With this patch the width is remembered in localStorage and preserved on refresh, making it less necessary to adjust. Signed-off-by: Ivan Babrou <github@ivan.computer>
bobrik
force-pushed
the
ivan/remember-width
branch
from
eed3116
to
718dbd6
Compare
yurishkuro
approved these changes
Jun 24, 2022
Codecov Report
@@ Coverage Diff @@
## main #965 +/- ##
==========================================
- Coverage 95.43% 95.37% -0.06%
==========================================
Files 242 242
Lines 7552 7554 +2
Branches 1889 1890 +1
==========================================
- Hits 7207 7205 -2
- Misses 338 342 +4
Partials 7 7
Continue to review full report at Codecov.
|
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Different developers tend to look at different kinds of traces, meaning that they often prefer some set width of span name column in trace view.
Without this patch, the width is set at 25% and it resets on refresh. With this patch the width is remembered in localStorage and preserved on refresh, making it less necessary to adjust.
Posting it without a backing issue since it's a tiny change.