Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update node version and use github-action for codecov #997

Merged
merged 4 commits into from
Oct 9, 2022
Merged

Update node version and use github-action for codecov #997

merged 4 commits into from
Oct 9, 2022

Conversation

mmorel-35
Copy link
Contributor

@mmorel-35 mmorel-35 commented Oct 8, 2022

Signed-off-by: Matthieu MOREL matthieu.morel35@gmail.com

Which problem is this PR solving?

Short description of the changes

  • Update node version and use github-action for codecov

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
@codecov
Copy link

codecov bot commented Oct 8, 2022

Codecov Report

Base: 95.34% // Head: 95.38% // Increases project coverage by +0.03% 🎉

Coverage data is based on head (bb0e53e) compared to base (57d5fa3).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #997      +/-   ##
==========================================
+ Coverage   95.34%   95.38%   +0.03%     
==========================================
  Files         243      243              
  Lines        7560     7560              
  Branches     1892     1895       +3     
==========================================
+ Hits         7208     7211       +3     
+ Misses        345      342       -3     
  Partials        7        7              
Impacted Files Coverage Δ
...nents/TracePage/TraceTimelineViewer/SpanBarRow.tsx 94.44% <0.00%> (-5.56%) ⬇️
packages/jaeger-ui/src/utils/date.tsx 94.73% <0.00%> (-2.64%) ⬇️
...mponents/TracePage/TraceStatistics/tableValues.tsx 96.20% <0.00%> (+2.41%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@yurishkuro
Copy link
Member

Fix upates failures because of outdated node 10 version

could you please elaborate which failures you're referring to?

mmorel-35 and others added 2 commits October 8, 2022 23:14
Co-authored-by: Yuri Shkuro <yurishkuro@users.noreply.github.com>
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
@mmorel-35
Copy link
Contributor Author

mmorel-35 commented Oct 8, 2022

could you please elaborate which failures you're referring to?

I found this one, to start with : https://github.com/jaegertracing/jaeger-ui/actions/runs/3186395354/jobs/5196939882

yurishkuro
yurishkuro previously approved these changes Oct 8, 2022
@yurishkuro yurishkuro enabled auto-merge (squash) October 8, 2022 23:30
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
auto-merge was automatically disabled October 9, 2022 08:21

Head branch was pushed to by a user without write access

@yurishkuro yurishkuro enabled auto-merge (squash) October 9, 2022 13:06
@yurishkuro yurishkuro merged commit cbc416e into jaegertracing:main Oct 9, 2022
@mmorel-35 mmorel-35 deleted the patch-1 branch October 10, 2022 04:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants