fix lint issues

Signed-off-by: Yuri Shkuro <github@ysh.us>
jaegertracing · Jun 16, 2024 · 0da4655 · 0da4655
1 parent 0b6b276
commit 0da4655
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 6 deletions.
diff --git a/cmd/jaeger/internal/extension/remotesampling/extension.go b/cmd/jaeger/internal/extension/remotesampling/extension.go
@@ -107,9 +107,7 @@ func GetSamplingStorage(
 
 func (ext *rsExtension) Start(ctx context.Context, host component.Host) error {
 	if ext.cfg.File.Path != "" {
-		// TODO contextcheck linter complains about next line that context is not passed. It is not wrong.
-		//nolint
-		if err := ext.startFileStrategyStore(); err != nil {
+		if err := ext.startFileStrategyStore(ctx); err != nil {
 			return err
 		}
 	}
@@ -152,12 +150,12 @@ func (ext *rsExtension) Shutdown(ctx context.Context) error {
 	return errors.Join(errs...)
 }
 
-func (ext *rsExtension) startFileStrategyStore() error {
+func (ext *rsExtension) startFileStrategyStore(_ context.Context) error {
 	opts := static.Options{
 		StrategiesFile: ext.cfg.File.Path,
 	}
 
-	// TODO contextcheck linter complains about next line that context is not passed. It is not wrong.
+	// contextcheck linter complains about next line that context is not passed.
 	//nolint
 	ss, err := static.NewStrategyStore(opts, ext.telemetry.Logger)
 	if err != nil {

diff --git a/cmd/jaeger/internal/processors/adaptivesampling/processor.go b/cmd/jaeger/internal/processors/adaptivesampling/processor.go
@@ -77,7 +77,7 @@ func (tp *traceProcessor) close(context.Context) error {
 	return nil
 }
 
-func (tp *traceProcessor) processTraces(ctx context.Context, td ptrace.Traces) (ptrace.Traces, error) {
+func (tp *traceProcessor) processTraces(_ context.Context, td ptrace.Traces) (ptrace.Traces, error) {
 	batches, err := otlp2jaeger.ProtoFromTraces(td)
 	if err != nil {
 		return td, fmt.Errorf("cannot transform OTLP traces to Jaeger format: %w", err)