#2048[WIP] - add tests to increase coverage

Signed-off-by: santosh <bsantosh@thoughtworks.com>

plugin/storage/es/factory_test.go

@@ -354,7 +354,7 @@ func TestGetSpanServiceMappings(t *testing.T) {
 			err: "",
 		},
 		{
-			name: "ES Version 7 Error",
+			name: "ES Version 7 Service Error",
 			args: args{
 				shards:    3,
 				replicas:  3,
@@ -392,7 +392,7 @@ func TestGetSpanServiceMappings(t *testing.T) {
 			err: "",
 		},
 		{
-			name: "ES Version < 7 Error",
+			name: "ES Version < 7 Service Error",
 			args: args{
 				shards:    3,
 				replicas:  3,
@@ -410,6 +410,42 @@ func TestGetSpanServiceMappings(t *testing.T) {
 			},
 			err: "template load error",
 		},
+		{
+			name: "ES Version < 7 Span Error",
+			args: args{
+				shards:    3,
+				replicas:  3,
+				esVersion: 6,
+				esPrefix:  "test",
+				useILM:    true,
+			},
+			mockNewTextTemplateBuilder: func() es.TemplateBuilder {
+				tb := mocks.TemplateBuilder{}
+				ta := mocks.TemplateApplier{}
+				ta.On("Execute", mock.Anything, mock.Anything).Return(errors.New("template load error"))
+				tb.On("Parse", mock.Anything).Return(&ta, nil)
+				return &tb
+			},
+			err: "template load error",
+		},
+		{
+			name: "ES Version  7 Span Error",
+			args: args{
+				shards:    3,
+				replicas:  3,
+				esVersion: 7,
+				esPrefix:  "test",
+				useILM:    true,
+			},
+			mockNewTextTemplateBuilder: func() es.TemplateBuilder {
+				tb := mocks.TemplateBuilder{}
+				ta := mocks.TemplateApplier{}
+				ta.On("Execute", mock.Anything, mock.Anything).Return(errors.New("template load error")).Once()
+				tb.On("Parse", mock.Anything).Return(&ta, nil)
+				return &tb
+			},
+			err: "template load error",
+		},
 	}
 	for _, test := range tests {
 		t.Run(test.name, func(t *testing.T) {