Skip to content

Commit

Permalink
Update Dockerfiles to reference executable via ENTRYPOINT
Browse files Browse the repository at this point in the history
- In all Dockerfiles, reference the executable in ENTRYPOINT to allow
consumers to override default parameters without needing to specify
the executable path.

- Common default arguments in the query and standalone Dockerfiles
also move to ENTRYPOINT

- Move hotrod default argument to CMD

Signed-off-by: Zachary DiCesare <zachary.v.dicesare@gmail.com>
  • Loading branch information
zdicesare committed May 15, 2018
1 parent a4706c0 commit 864d66b
Show file tree
Hide file tree
Showing 10 changed files with 13 additions and 12 deletions.
2 changes: 1 addition & 1 deletion cmd/agent/Dockerfile
Expand Up @@ -2,4 +2,4 @@ FROM scratch

EXPOSE 5775/udp 6831/udp 6832/udp 5778
COPY agent-linux /go/bin/
CMD ["/go/bin/agent-linux"]
ENTRYPOINT ["/go/bin/agent-linux"]
2 changes: 1 addition & 1 deletion cmd/collector/Dockerfile
Expand Up @@ -7,4 +7,4 @@ COPY --from=certs /etc/ssl/certs/ca-certificates.crt /etc/ssl/certs/ca-certifica

EXPOSE 14267
COPY collector-linux /go/bin/
CMD ["/go/bin/collector-linux"]
ENTRYPOINT ["/go/bin/collector-linux"]
2 changes: 1 addition & 1 deletion cmd/query/Dockerfile
Expand Up @@ -8,4 +8,4 @@ COPY --from=certs /etc/ssl/certs/ca-certificates.crt /etc/ssl/certs/ca-certifica
EXPOSE 16686
COPY query-linux /go/bin/
ADD jaeger-ui-build /go/jaeger-ui/
CMD ["/go/bin/query-linux", "--query.static-files=/go/jaeger-ui/"]
ENTRYPOINT ["/go/bin/query-linux", "--query.static-files=/go/jaeger-ui/"]
2 changes: 1 addition & 1 deletion cmd/standalone/Dockerfile
Expand Up @@ -22,4 +22,4 @@ COPY ./jaeger-ui-build /go/src/jaeger-ui-build
COPY ./cmd/standalone/standalone-linux /go/bin/
COPY ./cmd/standalone/sampling_strategies.json /go/src/config/

CMD ["/go/bin/standalone-linux","--query.static-files=/go/src/jaeger-ui-build/build/","--sampling.strategies-file=/go/src/config/sampling_strategies.json"]
ENTRYPOINT ["/go/bin/standalone-linux", "--query.static-files=/go/src/jaeger-ui-build/build/", "--sampling.strategies-file=/go/src/config/sampling_strategies.json"]
2 changes: 1 addition & 1 deletion crossdock/Dockerfile
Expand Up @@ -3,4 +3,4 @@ FROM scratch
COPY crossdock-linux /go/bin/

EXPOSE 8080
CMD ["/go/bin/crossdock-linux"]
ENTRYPOINT ["/go/bin/crossdock-linux"]
2 changes: 1 addition & 1 deletion crossdock/docker-compose.yml
Expand Up @@ -80,4 +80,4 @@ services:

jaeger-query:
# override to disable static files
command: ["/go/bin/query-linux", "--query.static-files=", "--cassandra.keyspace=jaeger_v1_dc1", "--cassandra.servers=cassandra"]
command: ["--query.static-files=", "--cassandra.keyspace=jaeger_v1_dc1", "--cassandra.servers=cassandra"]
6 changes: 3 additions & 3 deletions docker-compose/jaeger-docker-compose.yml
Expand Up @@ -3,7 +3,7 @@ version: '2'
services:
jaeger-collector:
image: jaegertracing/jaeger-collector
command: ["/go/bin/collector-linux", "--cassandra.keyspace=jaeger_v1_dc1", "--cassandra.servers=cassandra", "--collector.zipkin.http-port=9411"]
command: ["--cassandra.keyspace=jaeger_v1_dc1", "--cassandra.servers=cassandra", "--collector.zipkin.http-port=9411"]
ports:
- "14269"
- "14268:14268"
Expand All @@ -15,7 +15,7 @@ services:

jaeger-query:
image: jaegertracing/jaeger-query
command: ["/go/bin/query-linux", "--query.static-files=/go/jaeger-ui/", "--cassandra.keyspace=jaeger_v1_dc1", "--cassandra.servers=cassandra"]
command: ["--cassandra.keyspace=jaeger_v1_dc1", "--cassandra.servers=cassandra"]
ports:
- "16686:16686"
- "16687"
Expand All @@ -25,7 +25,7 @@ services:

jaeger-agent:
image: jaegertracing/jaeger-agent
command: ["/go/bin/agent-linux", "--collector.host-port=jaeger-collector:14267"]
command: ["--collector.host-port=jaeger-collector:14267"]
ports:
- "5775:5775/udp"
- "6831:6831/udp"
Expand Down
3 changes: 2 additions & 1 deletion examples/hotrod/Dockerfile
@@ -1,4 +1,5 @@
FROM scratch
EXPOSE 8080 8081 8082 8083
COPY hotrod-linux /go/bin/
ENTRYPOINT ["/go/bin/hotrod-linux", "all"]
ENTRYPOINT ["/go/bin/hotrod-linux"]
CMD ["all"]
2 changes: 1 addition & 1 deletion plugin/storage/cassandra/Dockerfile
Expand Up @@ -3,4 +3,4 @@ FROM cassandra:3.11
COPY schema/* /cassandra-schema/

ENV CQLSH_HOST=cassandra
CMD ["/cassandra-schema/docker.sh"]
ENTRYPOINT ["/cassandra-schema/docker.sh"]
2 changes: 1 addition & 1 deletion plugin/storage/es/Dockerfile
@@ -1,4 +1,4 @@
FROM python:3-alpine
RUN pip install elasticsearch elasticsearch-curator
COPY esCleaner.py /es-index-cleaner/
CMD ["python3", "/es-index-cleaner/esCleaner.py"]
ENTRYPOINT ["python3", "/es-index-cleaner/esCleaner.py"]

0 comments on commit 864d66b

Please sign in to comment.