Support log-level flag on agent

Signed-off-by: Won Jun Jang <wjang@uber.com>
jaegertracing · May 17, 2018 · 8e0a027 · 8e0a027
1 parent b5ade19
commit 8e0a027
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/cmd/agent/main.go b/cmd/agent/main.go
@@ -73,6 +73,7 @@ func main() {
 		v,
 		command,
 		flags.AddConfigFileFlag,
+		flags.AddLoggingFlag,
 		app.AddFlags,
 		metrics.AddFlags,
 	)

diff --git a/cmd/flags/flags.go b/cmd/flags/flags.go
@@ -77,8 +77,13 @@ func SetDefaultHealthCheckPort(port int) {
 // AddFlags adds flags for SharedFlags
 func AddFlags(flagSet *flag.FlagSet) {
 	flagSet.String(spanStorageType, "", fmt.Sprintf("Deprecated; please use %s environment variable", storage.SpanStorageTypeEnvVar))
-	flagSet.String(logLevel, "info", "Minimal allowed log Level. For more levels see https://github.com/uber-go/zap")
 	flagSet.Int(healthCheckHTTPPort, defaultHealthCheckPort, "The http port for the health check service")
+	AddLoggingFlag(flagSet)
+}
+
+// AddLoggingFlag adds logging flag for SharedFlags
+func AddLoggingFlag(flagSet *flag.FlagSet) {
+	flagSet.String(logLevel, "info", "Minimal allowed log Level. For more levels see https://github.com/uber-go/zap")
 }
 
 // InitFromViper initializes SharedFlags with properties from viper