fix

Signed-off-by: Pushkar Mishra <pushkarmishra029@gmail.com>
jaegertracing · May 12, 2024 · 976ee74 · 976ee74
1 parent c0878ad
commit 976ee74
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 6 deletions.
diff --git a/plugin/sampling/strategystore/adaptive/aggregator.go b/plugin/sampling/strategystore/adaptive/aggregator.go
@@ -144,9 +144,9 @@ func (a *aggregator) Close() error {
 	if err := a.postAggregator.Close(); err != nil {
 		errs = append(errs, err)
 	}
-	// if a.stop != nil {
-	// 	close(a.stop)
-	// }
+	if a.stop != nil {
+		close(a.stop)
+	}
 	a.bgFinished.Wait()
 	return errors.Join(errs...)
 }

diff --git a/plugin/sampling/strategystore/adaptive/postaggregator.go b/plugin/sampling/strategystore/adaptive/postaggregator.go
@@ -160,9 +160,6 @@ func (p *PostAggregator) runBackground(f func()) {
 func (p *PostAggregator) Close() error {
 	p.logger.Info("stopping adaptive sampling processor")
 	err := p.electionParticipant.Close()
-	if p.shutdown != nil {
-		close(p.shutdown)
-	}
 	p.bgFinished.Wait()
 	return err
 }