More tests

Signed-off-by: Yuri Shkuro <ys@uber.com>
jaegertracing · Oct 24, 2017 · b026119 · b026119
1 parent 171e303
commit b026119
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 0 deletions.
diff --git a/cmd/query/app/fixture/index.html b/cmd/query/app/fixture/index.html
@@ -2,4 +2,5 @@
 <html lang="en">
     <meta charset="UTF-8">
     <title>Test Page</title>
+    <!-- JAEGER_CONFIG=DEFAULT_CONFIG; -->
 </html>
diff --git a/cmd/query/app/static_handler_test.go b/cmd/query/app/static_handler_test.go
@@ -19,6 +19,7 @@ import (
 	"io/ioutil"
 	"net/http"
 	"net/http/httptest"
+	"strings"
 	"testing"
 	"time"
 
@@ -75,6 +76,17 @@ func TestRegisterRoutesHandler(t *testing.T) {
 	assert.Equal(t, expectedRespString, respString)
 }
 
+func TestNewStaticAssetsHandlerWithConfig(t *testing.T) {
+	_, err := NewStaticAssetsHandler("fixture", "fixture/invalid-config")
+	assert.Error(t, err)
+
+	handler, err := NewStaticAssetsHandler("fixture", "fixture/ui-config.json")
+	require.NoError(t, err)
+	require.NotNil(t, handler)
+	html := string(handler.indexHTML)
+	assert.True(t, strings.Contains(html, `JAEGER_CONFIG = {"x":"y"};`), "actual: %v", html)
+}
+
 func TestLoadUIConfig(t *testing.T) {
 	type testCase struct {
 		configFile    string