Skip to content

Commit

Permalink
Clean-up coverage, go fmt
Browse files Browse the repository at this point in the history
Signed-off-by: Yuri Shkuro <ys@uber.com>
  • Loading branch information
Yuri Shkuro committed Jun 1, 2018
1 parent ab079e5 commit cc4e0e4
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 6 deletions.
3 changes: 2 additions & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,8 @@ cover: nocover
@echo pre-compiling tests
@time go test -i $(ALL_PKGS)
@./scripts/cover.sh $(shell go list $(TOP_PKGS))
go tool cover -html=cover.out -o cover.html
egrep -v 'jaeger.pb.*.go' cover.out > cover-nogen.out
go tool cover -html=cover-nogen.out -o cover.html

.PHONY: nocover
nocover:
Expand Down
8 changes: 4 additions & 4 deletions model/model_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -63,24 +63,24 @@ func TestProto(t *testing.T) {
StartTime: time.Now(),
Duration: 42 * time.Microsecond,
References: []SpanRef{
SpanRef{
{
TraceID: TraceID{Low: 123},
SpanID: SpanID(456),
RefType: SpanRefType_CHILD_OF,
},
},
Tags: []KeyValue{
KeyValue{
{
Key: "baz",
VType: ValueType_STRING,
VStr: "foo bar",
},
},
Logs: []Log{
Log{
{
Timestamp: time.Now(),
Fields: []KeyValue{
KeyValue{
{
Key: "baz",
VType: ValueType_STRING,
VStr: "foo bar",
Expand Down
2 changes: 1 addition & 1 deletion scripts/updateLicenses.sh
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,4 @@

set -e

python scripts/updateLicense.py $(git ls-files "*\.go" | grep -v -e thrift-gen -e swagger-gen -e bindata_assetfs.go)
python scripts/updateLicense.py $(git ls-files "*\.go" | grep -v -e thrift-gen -e swagger-gen -e bindata_assetfs.go -e jaeger.pb.go -e jaeger.pb.gw.go)

0 comments on commit cc4e0e4

Please sign in to comment.