Skip to content

Commit

Permalink
Use withResolver API in gRPC reporter (#3078)
Browse files Browse the repository at this point in the history
* Use withResolver API in gRPC reporter

Signed-off-by: Pavol Loffay <p.loffay@gmail.com>

* Use manual

Signed-off-by: Pavol Loffay <p.loffay@gmail.com>

* fmt

Signed-off-by: Pavol Loffay <p.loffay@gmail.com>
  • Loading branch information
pavolloffay committed Jun 11, 2021
1 parent 3f96a96 commit e33977e
Showing 1 changed file with 2 additions and 12 deletions.
14 changes: 2 additions & 12 deletions cmd/agent/app/reporter/grpc/builder.go
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,7 @@ import (
"context"
"errors"
"fmt"
"strconv"
"strings"
"time"

grpc_retry "github.com/grpc-ecosystem/go-grpc-middleware/retry"
"github.com/uber/jaeger-lib/metrics"
Expand Down Expand Up @@ -82,7 +80,8 @@ func (b *ConnBuilder) CreateConnection(logger *zap.Logger, mFactory metrics.Fact
return nil, errors.New("at least one collector hostPort address is required when resolver is not available")
}
if len(b.CollectorHostPorts) > 1 {
r, _ := generateAndRegisterManualResolver()
r := manual.NewBuilderWithScheme("jaeger_manual")
dialOptions = append(dialOptions, grpc.WithResolvers(r))
var resolvedAddrs []resolver.Address
for _, addr := range b.CollectorHostPorts {
resolvedAddrs = append(resolvedAddrs, resolver.Address{Addr: addr})
Expand Down Expand Up @@ -125,12 +124,3 @@ func (b *ConnBuilder) CreateConnection(logger *zap.Logger, mFactory metrics.Fact

return conn, nil
}

// generateAndRegisterManualResolver was removed from grpc.
// Copied here to keep behavior the same.
func generateAndRegisterManualResolver() (*manual.Resolver, func()) {
scheme := strconv.FormatInt(time.Now().UnixNano(), 36)
r := manual.NewBuilderWithScheme(scheme)
resolver.Register(r)
return r, func() { resolver.UnregisterForTesting(scheme) }
}

0 comments on commit e33977e

Please sign in to comment.