Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure that proto/grpc dependencies are in sync with generated files #1431

Closed
yurishkuro opened this issue Mar 19, 2019 · 0 comments
Closed

Ensure that proto/grpc dependencies are in sync with generated files #1431

yurishkuro opened this issue Mar 19, 2019 · 0 comments

Comments

@yurishkuro
Copy link
Member

We don't have a validation step to ensure that the proto-generated source code is consistent with the versions of declared dependencies. For example, as of 8e76a50 (Mar 19 2019), there are the following differences:

$ dep ensure
$ make proto-install
$ make proto
$ git status
	modified:   proto-gen/api_v2/api_v2.pb.gw.go
	modified:   proto-gen/openapi/api_v2.swagger.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@yurishkuro