Verify that proto-generated files are up-to-date #1433
Conversation
Signed-off-by: Yuri Shkuro <ys@uber.com>
yurishkuro
requested review from
black-adder,
jpkrohling,
objectiser,
pavolloffay,
tiffon and
vprithvi
as code owners
Signed-off-by: Yuri Shkuro <ys@uber.com>
|
Verification that the test works: https://travis-ci.org/jaegertracing/jaeger/jobs/508563896#L626
|
Signed-off-by: Yuri Shkuro <ys@uber.com>
Codecov Report
@@ Coverage Diff @@
## master #1433 +/- ##
======================================
Coverage 100% 100%
======================================
Files 165 165
Lines 7538 7538
======================================
Hits 7538 7538Continue to review full report at Codecov.
|
|
Crossdock test came back green on re-run. Booked #1434 for that. |
| @@ -11,6 +11,9 @@ matrix: | |||
| env: | |||
| - TESTS=true | |||
| - COVERAGE=true | |||
| - go: "1.11.1" | |||
There was a problem hiding this comment.
at this rate we're going to hit the 1 hour mark for CI, we should do some research into smarter CI or combine some steps into 1.
There was a problem hiding this comment.
most steps = more parallelization. The real issue is that Travis is throttling us on the number of concurrent steps.
| @@ -397,5 +398,4 @@ proto-install: | |||
| ./vendor/github.com/gogo/protobuf/protoc-gen-gogo \ | |||
| ./vendor/github.com/grpc-ecosystem/grpc-gateway/protoc-gen-grpc-gateway \ | |||
| ./vendor/github.com/grpc-ecosystem/grpc-gateway/protoc-gen-swagger | |||
| # ./vendor/github.com/mwitkow/go-proto-validators/protoc-gen-govalidators \ | |||
| # ./vendor/github.com/rakyll/statik | |||
| # ./vendor/github.com/mwitkow/go-proto-validators/protoc-gen-govalidators | |||
There was a problem hiding this comment.
can we remove if it's commented out?
Resolves #1431