Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tracking] Patch release 1.17.1 #2093

Closed
yurishkuro opened this issue Feb 27, 2020 · 11 comments
Closed

[tracking] Patch release 1.17.1 #2093

yurishkuro opened this issue Feb 27, 2020 · 11 comments
Labels
meta-issue An tracking issue that requires work in other repos

Comments

@yurishkuro
Copy link
Member

@ghost ghost added the needs-triage label Feb 27, 2020
@jpkrohling
Copy link
Contributor

Possibly #2094 too?

@jpkrohling jpkrohling added meta-issue An tracking issue that requires work in other repos and removed needs-triage labels Feb 27, 2020
@pavolloffay
Copy link
Member

Do we want to release from release branch or master? Since the release we have migrated go modules.

@yurishkuro
Copy link
Member Author

I prefer to release from master. Go modules is not a breaking change.

@pavolloffay
Copy link
Member

In master there are couple of breaking changes. We will have to relase from release branch. I have created release-1.17 after migration to go modules and proto generation refactoring by @annanay25. I have also backported the TLS fix.

https://github.com/jaegertracing/jaeger/commits/release-1.17

Now the UI fix has to be merged and UI released and updated here.

@objectiser
Copy link
Contributor

@yurishkuro Could we also get jaegertracing/jaeger-ui#542 included in the UI release?

@pavolloffay
Copy link
Member

All blocking PRs have been merged. We can proceed with the release. We need a patch release of the UI (1.7.1) and bump it here.

@pavolloffay
Copy link
Member

Release UI jaegertracing/jaeger-ui#543

@pavolloffay
Copy link
Member

We should agree and document when the changelog should be updated. I don't find it very useful to update it for patch releases. It adds unnecessary overhead.

@objectiser
Copy link
Contributor

objectiser commented Mar 11, 2020

I think the fixed bugs need to be documented atleast on the GH release page, and may be add to the CHANGELOG for the next minor release?

@yurishkuro
Copy link
Member Author

I don't think we should diverge GH releases and the changelog. What's the downside of adding a patch release to the changelog?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta-issue An tracking issue that requires work in other repos
Projects
None yet
Development

No branches or pull requests

4 participants