Preparing release 1.8.0 #543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rubenvp8510
reviewed
Mar 11, 2020
CHANGELOG.md
Outdated
| - **General:** bump url-parse version to 1.4.7 ([#542](https://github.com/jaegertracing/jaeger-ui/pull/542), [@rubenvp8510](https://github.com/rubenvp8510)) | ||
| - **Search** Fix span links for leading 0s trace ID ([#539](https://github.com/jaegertracing/jaeger-ui/pull/539), [@everett980](https://github.com/everett980)) | ||
| - **General:** Reorder, rename, and fix "About Jaeger" links ([#540](https://github.com/jaegertracing/jaeger-ui/pull/540), [@yurishkuro](https://github.com/yurishkuro)) | ||
| - **Search:** Fix search.maxLimit configuration ([#533](https://github.com/jaegertracing/jaeger-ui/pull/533), [@rubenvp8510](https://github.com/rubenvp8510)) |
There was a problem hiding this comment.
There are two spaces between the title and the PR link
rubenvp8510
reviewed
Mar 11, 2020
| - **Trace detail:** Fix trace scoped links not supporting numeric fields ([#538](https://github.com/jaegertracing/jaeger-ui/pull/538), [@william-tran](https://github.com/william-tran)) | ||
| - **Search:** Search results link spans ([#536](https://github.com/jaegertracing/jaeger-ui/pull/536), [@everett980](https://github.com/everett980)) | ||
|
|
||
|
|
There was a problem hiding this comment.
Remove one of the empty lines.
Codecov Report
@@ Coverage Diff @@
## master #543 +/- ##
==========================================
- Coverage 92.98% 92.94% -0.05%
==========================================
Files 197 197
Lines 4848 4848
Branches 1177 1177
==========================================
- Hits 4508 4506 -2
- Misses 300 302 +2
Partials 40 40
Continue to review full report at Codecov.
|
yurishkuro
reviewed
Mar 11, 2020
CHANGELOG.md
Outdated
|
|
||
| - **Trace detail:** Fix trace scoped links not supporting numeric fields ([#538](https://github.com/jaegertracing/jaeger-ui/pull/538), [@william-tran](https://github.com/william-tran)) | ||
|
|
||
| - **Search:** Search results link spans ([#536](https://github.com/jaegertracing/jaeger-ui/pull/536), [@everett980](https://github.com/everett980)) |
There was a problem hiding this comment.
this is a new feature, I believe, and because of that @everett980 mentioned offline that we may want to do a minor release, not a patch.
There was a problem hiding this comment.
Alright I will move it and change the version
Signed-off-by: Pavol Loffay <ploffay@redhat.com>
Signed-off-by: Pavol Loffay <ploffay@redhat.com>
Signed-off-by: Pavol Loffay <ploffay@redhat.com>
pavolloffay
force-pushed
the
release-1.7.1
branch
from
3f4de11
to
443939b
Compare
yurishkuro
approved these changes
Mar 12, 2020
CHANGELOG.md
Outdated
| @@ -1,5 +1,20 @@ | |||
| # Releases | |||
|
|
|||
| ## v1.7.1 (March 12, 2020) | |||
Signed-off-by: Pavol Loffay <ploffay@redhat.com>
yurishkuro
approved these changes
Mar 12, 2020
|
if I am not mistaken, prettier doesn't like something in the changelog |
|
I think the linter is complaining because of this: Check the double space between configuration and the first parenthesis. |
Signed-off-by: Pavol Loffay <ploffay@redhat.com>
vvvprabhakar
pushed a commit
to vvvprabhakar/jaeger-ui
that referenced
this pull request
Jul 5, 2021
* Preparing release 1.7.1 Signed-off-by: Pavol Loffay <ploffay@redhat.com> * Update changelog Signed-off-by: Pavol Loffay <ploffay@redhat.com> * Update version Signed-off-by: Pavol Loffay <ploffay@redhat.com> * Fix verson Signed-off-by: Pavol Loffay <ploffay@redhat.com> * Remove double space Signed-off-by: Pavol Loffay <ploffay@redhat.com> Signed-off-by: vvvprabhakar <vvvprabhakar@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Pavol Loffay ploffay@redhat.com