New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: Jaeger not respecting JAEGER_DISABLED=true #5385
Comments
@yurishkuro I have also tried with it and traces are appearing as mentioned above in issue. I think we need a fix for this |
what is JAEGER_DISABLED? Where is it documented? |
I think he introduced a variable in such a way that he can stop Jaeger 😅. I just tested with his docker file. He may assuming with that JAEGER_DISABLED=true get Jaeger stop from working. Maybe he referred wrong documentation or previous one . I think we get clarified from his response of where he referred that variable. |
@tomsiwik Can we get the link of documentation where you referred it? |
Hey, sorry for the late response - different timezones I guess. It's mentioned here: https://www.jaegertracing.io/docs/1.25/monitoring/#traces |
But it mentioned to keep that variable while docker run. You have explicitly introduced in Dockerfile instead at docker run cd. Once give it try and let us know
|
Got it! Samething resulting getting confused about this variable. There mentioned the traces are of its own components of query service. Maybe @yurishkuro will know the clear context of this |
True. Regardless of the naming |
Hey, I'm having the same issue. Downgrading to jaegertracing 1.47 solved this issue (there is no |
@yurishkuro PTAL |
Since we switched to OTEL SDKs (from v1.48.0) this setting is no longer applicable. We need to change the docs (retroactively). There is a setting for OTEL SDK which will have similar effect: |
another thing we could do is remap that var, but the prod binaries don't seem to call this function, only hotrod does
|
## Which problem is this PR solving? - Part of jaegertracing/jaeger#5385 ## Description of the changes - Use OTEL env var that works with OTEL SDKs - Update all docs starting from v1.48, when OTEL SDK were introduced ## How was this change tested? - Verified that starting all-in-one as below does not generate traces ``` $ OTEL_TRACES_SAMPLER=always_off go run -tags=ui ./cmd/all-in-one ``` Signed-off-by: Yuri Shkuro <github@ysh.us>
I updated the docs |
Thanks for reporting! |
What happened?
I'm trying to run jaeger without it's own traces in docker (using environment variable as stated in the documentation). However, when I open the UI and refresh the page the traces are still logged. I've tried pruning/killing all docker images and volumes to no effect.
Steps to reproduce
docker-compose up -d
with exampledocker-compose.yml
docker run -e JAEGER_DISABLED=true -p 16686:16686 jaegertracing/all-in-one:1.56
http://localhost:16686/
Expected behavior
Traces of
jaeger-all-in-one
should not be visibleRelevant log output
No response
Screenshot
Additional context
No response
Jaeger backend version
latest
SDK
No response
Pipeline
No response
Stogage backend
No response
Operating system
M1 Mac
Deployment model
docker,docker-compose
Deployment configs
docker-compose.yml
The text was updated successfully, but these errors were encountered: