Use current code, not published images, in ES integration tests #5709
Labels
good first issue
Good for beginners
help wanted
Features that maintainers are willing to accept but do not have cycles to implement
jaeger/plugin/storage/integration/es_index_cleaner_test.go
Lines 35 to 36 in 3b9428e
This test is invoked from
scripts/es-integration-test.sh
.Here the test is using
:latest
build of the helper containers. This is what happens in the CI:In other words, instead of testing the current code (which could've been changed in the PR under test), we are using a published image built from the main branch.
We need to refactor this test. Since these helper containers are not used in any other CI workflows, it's good to test them in this workflow. We need to build the containers locally similar to this other script:
jaeger/scripts/build-upload-docker-images.sh
Lines 61 to 62 in 3b9428e
And then use a specific tag (not
:latest
) when executing the test.The text was updated successfully, but these errors were encountered: