Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support building just the ingester #1033

Closed
wants to merge 1 commit into from

Conversation

zoidyzoidzoid
Copy link
Contributor

Which problem is this PR solving?

Wanting to build just the ingester

Short description of the changes

  • Add Makefile job to just build the ingester
  • Ignore the ingester binaries in the .gitignore
  • Whitespace that my editor wanted at the end of the Makefile ( I can revert it)

@codecov
Copy link

codecov bot commented Aug 30, 2018

Codecov Report

Merging #1033 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #1033    +/-   ##
=======================================
  Coverage     100%    100%            
=======================================
  Files         140     139     -1     
  Lines        6622    6415   -207     
=======================================
- Hits         6622    6415   -207
Impacted Files Coverage Δ
cmd/ingester/app/consumer/message.go 100% <0%> (ø) ⬆️
plugin/storage/cassandra/spanstore/reader.go 100% <0%> (ø) ⬆️
cmd/collector/app/model_consumer.go 100% <0%> (ø) ⬆️
cmd/collector/app/metrics.go 100% <0%> (ø) ⬆️
storage/spanstore/metrics/decorator.go 100% <0%> (ø) ⬆️
cmd/agent/app/servers/server.go 100% <0%> (ø) ⬆️
plugin/storage/es/spanstore/writer.go 100% <0%> (ø) ⬆️
model/converter/thrift/jaeger/to_domain.go 100% <0%> (ø) ⬆️
model/converter/thrift/zipkin/process_hashtable.go 100% <0%> (ø) ⬆️
cmd/collector/app/service_name_normalizer.go 100% <0%> (ø) ⬆️
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 01ff822...8581a8b. Read the comment docs.

@vprithvi
Copy link
Contributor

Thanks for your contribution! Could you sign off the DCO as detailed here.

This looks good to me. While you are at it, could you add the ingester target to the build-platform-binaries targets as well?

@yurishkuro
Copy link
Member

I think this partially addresses #1031, but it's missing the actual packaging steps for the Docker images and the executable uploaded as archive to GitHub releases.

@zoidbergwill was your intention to solve #1031?

Signed-off-by: William Stewart <zoidbergwill@gmail.com>
@pavolloffay
Copy link
Member

thanks for the PR @zoidbergwill. It seems that this is already done in master and #1031 is resolved.

Just doing before winter cleaning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants