Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a metric for number of partitions held #1154

Merged
merged 2 commits into from Oct 31, 2018

Conversation

Projects
None yet
3 participants
@vprithvi
Copy link
Member

vprithvi commented Oct 30, 2018

ref #1126

Signed-off-by: Prithvi Raj p.r@uber.com

Add a metric for number of partitions held
ref #1126

Signed-off-by: Prithvi Raj <p.r@uber.com>
@codecov

This comment has been minimized.

Copy link

codecov bot commented Oct 31, 2018

Codecov Report

Merging #1154 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1154   +/-   ##
======================================
  Coverage     100%    100%           
======================================
  Files         144     144           
  Lines        6769    6774    +5     
======================================
+ Hits         6769    6774    +5
Impacted Files Coverage Δ
cmd/ingester/app/consumer/consumer.go 100% <100%> (ø) ⬆️
cmd/ingester/app/consumer/consumer_metrics.go 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3dfc8c3...ad9f4fd. Read the comment docs.

@yurishkuro yurishkuro merged commit bf714e1 into master Oct 31, 2018

4 of 5 checks passed

License Compliance 32 issues found
Details
codecov/patch 100% of diff hit (target 100%)
Details
codecov/project 100% (target 100%)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@wafflebot wafflebot bot removed the review label Oct 31, 2018

@yurishkuro

This comment has been minimized.

Copy link
Member

yurishkuro commented Oct 31, 2018

@vprithvi saying "ref #1126" does not auto-close the ticket on merge, please use Fixes or Resolves.

ledor473 added a commit to ticketmaster/jaeger that referenced this pull request Nov 1, 2018

@pavolloffay pavolloffay deleted the add-partitions-held branch Nov 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.