Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare release 1.8 #1170

Merged
merged 2 commits into from
Nov 13, 2018
Merged

Conversation

pavolloffay
Copy link
Member

@pavolloffay pavolloffay commented Nov 12, 2018

Resolves #1150

Signed-off-by: Pavol Loffay ploffay@redhat.com

Signed-off-by: Pavol Loffay <ploffay@redhat.com>
@codecov
Copy link

codecov bot commented Nov 12, 2018

Codecov Report

Merging #1170 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1170   +/-   ##
======================================
  Coverage     100%    100%           
======================================
  Files         144     144           
  Lines        6822    6839   +17     
======================================
+ Hits         6822    6839   +17
Impacted Files Coverage Δ
cmd/ingester/app/consumer/deadlock_detector.go 100% <0%> (ø) ⬆️
cmd/ingester/app/consumer/consumer.go 100% <0%> (ø) ⬆️
cmd/ingester/app/flags.go 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be62816...408ace0. Read the comment docs.

CHANGELOG.md Outdated
- Rename `params.Factory` to `params.MetricFactory` ([#1146](https://github.com/jaegertracing/jaeger/pull/1146), [@vprithvi](https://github.com/vprithvi))
- Fix child span context while tracing cassandra queries ([#1131](https://github.com/jaegertracing/jaeger/pull/1131), [@annanay25](https://github.com/annanay25))
- Support tracer env based initialization in hotrod ([#1115](https://github.com/jaegertracing/jaeger/pull/1115), [@eundoosong](https://github.com/eundoosong))
- Deadlock detector hack for Kafka driver instability ([#1087](https://github.com/jaegertracing/jaeger/pull/1087), [@vprithvi](https://github.com/vprithvi))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we should include #1134. I did a master merge to see if the build is clean.

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
@pavolloffay
Copy link
Member Author

Can we also get jaegertracing/jaeger-ui#263 resolved and include it in this release? We would like to have it in 1.8

@yurishkuro
Copy link
Member

I expect the embedded UI PR to still go through a few review iterations for a few days (and Joe is traveling this week, he may not have a lot of time to look at it). I would suggest not blocking on it.

@objectiser
Copy link
Contributor

Would we be able to do a patch release once the ui change is ready?

@yurishkuro
Copy link
Member

yes, but we might want to do it from a branch off of the 1.8 version, since we're planning to merge other breaking PRs right after the release.

Signed-off-by: Pavol Loffay <ploffay@redhat.com>
@pavolloffay
Copy link
Member Author

Cool I wanted to check the same. Then I guess we can go ahead and merge this today/tomorrow. The docs are updated jaegertracing/documentation#167. The only missing part is the architecture diagram which can be done later.

@yurishkuro yurishkuro merged commit 680b996 into jaegertracing:master Nov 13, 2018
@ghost ghost removed the review label Nov 13, 2018
@yurishkuro
Copy link
Member

wait, did you want to change the flag by removing the "collector" part?

@yurishkuro
Copy link
Member

I'll hold on doing the release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants