Use Zipkin annotations if the timestamp is zero #1341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geobeau
requested review from
black-adder,
jpkrohling,
objectiser,
pavolloffay,
tiffon,
vprithvi and
yurishkuro
as code owners
yurishkuro
reviewed
Feb 13, 2019
| if cs != nil { | ||
| timestamp = cs.Timestamp | ||
| cr := td.findAnnotation(zSpan, zipkincore.CLIENT_RECV) | ||
| if cr != nil { |
There was a problem hiding this comment.
should this perhaps also check for duration == 0?
Signed-off-by: Geoffrey Beausire <g.beausire@criteo.com>
Signed-off-by: Geoffrey Beausire <g.beausire@criteo.com>
Codecov Report
@@ Coverage Diff @@
## master #1341 +/- ##
======================================
Coverage 100% 100%
======================================
Files 162 162
Lines 7308 7326 +18
======================================
+ Hits 7308 7326 +18
Continue to review full report at Codecov.
|
|
@geobeau thanks for the PR? Was there a related ticket, or just the PR? |
|
No, I encountered this issue so I fixed it directly. Should I have opened one? Thanks to both of you 👍 |
|
no, PR is fine, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
When the span.Timestamp is 0, jaeger write the span with the timestamp to zero even when we have more informations in the annotations.
Short description of the changes
If the timestamp is zero, we determine if the span is a client or a server and extract timestamp and information from there