Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow changing max log level for gRPC storage plugins #1962

Merged
merged 4 commits into from Dec 5, 2019
Merged

Allow changing max log level for gRPC storage plugins #1962

merged 4 commits into from Dec 5, 2019

Conversation

yyyogev
Copy link
Contributor

@yyyogev yyyogev commented Dec 4, 2019

Which problem is this PR solving?

Short description of the changes

  • Add flag grpc-storage-plugin.log-level to set the level of the grpc plugin logger

@yyyogev
Add support for CLI flag grpc-storage-plugin.log-level
200ea18 
Signed-off-by: yyyogev <yogev.metzuyanim@logz.io>
@yyyogev
Add test for grpc log level
67b5bc3 
Signed-off-by: yyyogev <yogev.metzuyanim@logz.io>
@yyyogev
Fix log level flag description
1c9df8f 
Signed-off-by: yyyogev <yogev.metzuyanim@logz.io>
@yyyogev
fix formatting
ccff013 
Signed-off-by: yyyogev <yogev.metzuyanim@logz.io>
@codecov
Copy link

codecov bot commented Dec 4, 2019 •
edited

Codecov Report

Merging #1962 into master will increase coverage by <.01%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1962      +/-   ##
==========================================
+ Coverage   98.46%   98.46%   +<.01%     
==========================================
  Files         199      199              
  Lines        9875     9877       +2     
==========================================
+ Hits         9723     9725       +2     
- Misses        115      116       +1     
+ Partials       37       36       -1
Impacted Files Coverage Δ
plugin/storage/grpc/config/config.go 0% <0%> (ø) ⬆️
plugin/storage/grpc/options.go 100% <100%> (ø) ⬆️
plugin/storage/badger/spanstore/reader.go 96.79% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 85b2d2a...ccff013. Read the comment docs.

yurishkuro
yurishkuro approved these changes Dec 5, 2019
View reviewed changes
Copy link
Member

@yurishkuro yurishkuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@yurishkuro yurishkuro merged commit e9216d9 into jaegertracing:master Dec 5, 2019
@yurishkuro yurishkuro changed the title Add grpc log level Allow changing max log level for gRPC storage plugins Dec 5, 2019
@yurishkuro yurishkuro added this to the Release 1.16 milestone Dec 5, 2019
@yyyogev yyyogev deleted the add-grpc-log-level branch December 5, 2019 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yurishkuro yurishkuro yurishkuro approved these changes

@black-adder black-adder Awaiting requested review from black-adder

@jpkrohling jpkrohling Awaiting requested review from jpkrohling

@objectiser objectiser Awaiting requested review from objectiser

@pavolloffay pavolloffay Awaiting requested review from pavolloffay

@tiffon tiffon Awaiting requested review from tiffon

@vprithvi vprithvi Awaiting requested review from vprithvi

Assignees
No one assigned
Labels
changelog:bugfix-or-minor-feature
Projects
None yet
Milestone
Release 1.16
Development

Successfully merging this pull request may close these issues.

gRPC storage plugins - how to debug?
2 participants
@yyyogev @yurishkuro