Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plaintext as supported kafka auth option #2721

Merged
merged 1 commit into from
Jan 11, 2021

Conversation

pdepaepe
Copy link
Contributor

Hello Jaeger Team,

This tiny patch will simply add "plaintext" as one of the supported Kafka authentication in the CLI options.

Thanks for your awesome work on this project.

Signed-off-by: Pierre De Paepe pierre.de-paepe@ovhcloud.com

Signed-off-by: Pierre De Paepe <pierre.de-paepe@ovhcloud.com>
@pdepaepe pdepaepe requested a review from a team as a code owner January 11, 2021 15:10
@codecov
Copy link

codecov bot commented Jan 11, 2021

Codecov Report

Merging #2721 (9cfe059) into master (2f8ffa9) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2721      +/-   ##
==========================================
+ Coverage   95.73%   95.75%   +0.02%     
==========================================
  Files         216      216              
  Lines        9599     9599              
==========================================
+ Hits         9190     9192       +2     
+ Misses        336      335       -1     
+ Partials       73       72       -1     
Impacted Files Coverage Δ
cmd/query/app/static_handler.go 96.52% <0.00%> (+1.73%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f8ffa9...9cfe059. Read the comment docs.

@yurishkuro yurishkuro merged commit dc091c5 into jaegertracing:master Jan 11, 2021
bhiravabhatla pushed a commit to bhiravabhatla/jaeger that referenced this pull request Jan 25, 2021
…ing#2721)

Signed-off-by: Pierre De Paepe <pierre.de-paepe@ovhcloud.com>

Co-authored-by: Pierre De Paepe <pierre.de-paepe@ovhcloud.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants