Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[refactor] Minor clean-up of #2657 #2728

Merged
merged 2 commits into from
Jan 13, 2021
Merged

[refactor] Minor clean-up of #2657 #2728

merged 2 commits into from
Jan 13, 2021

Conversation

yurishkuro
Copy link
Member

No description provided.

@yurishkuro
[refactor] Minor clean-up of jaegertracing#2657
4e662be 
Signed-off-by: Yuri Shkuro <github@ysh.us>
@yurishkuro yurishkuro requested a review from a team as a code owner January 13, 2021 21:30
@mergify mergify bot requested a review from jpkrohling January 13, 2021 21:30
@yurishkuro yurishkuro mentioned this pull request Jan 13, 2021
Merged
@codecov
Copy link

codecov bot commented Jan 13, 2021 •
edited
Loading

Codecov Report

Merging #2728 (08e2e54) into master (2f8ffa9) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2728   +/-   ##
=======================================
  Coverage   95.73%   95.74%           
=======================================
  Files         216      217    +1     
  Lines        9599     9620   +21     
=======================================
+ Hits         9190     9211   +21     
  Misses        336      336           
  Partials       73       73
Impacted Files Coverage Δ
cmd/agent/app/reporter/connect_metrics.go 100.00% <100.00%> (ø)
cmd/agent/app/reporter/grpc/builder.go 95.83% <100.00%> (+0.83%) ⬆️
cmd/agent/app/reporter/grpc/collector_proxy.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b1ecb5b...08e2e54. Read the comment docs.

@yurishkuro
add test
08e2e54 
Signed-off-by: Yuri Shkuro <github@ysh.us>
@yurishkuro yurishkuro merged commit 893c837 into jaegertracing:master Jan 13, 2021
@yurishkuro yurishkuro deleted the fix-2657 branch January 13, 2021 22:59
bhiravabhatla pushed a commit to bhiravabhatla/jaeger that referenced this pull request Jan 25, 2021
@yurishkuro @bhiravabhatla
[refactor] Minor clean-up of jaegertracing#2657 (jaegertracing#2728)
b980e87 
* [refactor] Minor clean-up of jaegertracing#2657

Signed-off-by: Yuri Shkuro <github@ysh.us>

* add test

Signed-off-by: Yuri Shkuro <github@ysh.us>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavolloffay pavolloffay Awaiting requested review from pavolloffay

@jpkrohling jpkrohling Awaiting requested review from jpkrohling

Assignees

@jpkrohling jpkrohling

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yurishkuro @jpkrohling