Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable stale bot for PRs and questions #2731

Merged
merged 4 commits into from
Jan 20, 2021

Conversation

yurishkuro
Copy link
Member

Resolves #2717

@jpkrohling PTAL

@yurishkuro yurishkuro requested a review from a team as a code owner January 16, 2021 01:09
@yurishkuro yurishkuro requested review from pavolloffay and jpkrohling and removed request for pavolloffay January 16, 2021 01:09
@codecov
Copy link

codecov bot commented Jan 16, 2021

Codecov Report

Merging #2731 (90f8029) into master (748bf21) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2731   +/-   ##
=======================================
  Coverage   95.82%   95.82%           
=======================================
  Files         217      217           
  Lines        9650     9650           
=======================================
  Hits         9247     9247           
- Misses        331      332    +1     
+ Partials       72       71    -1     
Impacted Files Coverage Δ
...lugin/sampling/strategystore/adaptive/processor.go 99.07% <0.00%> (-0.93%) ⬇️
cmd/query/app/static_handler.go 96.77% <0.00%> (+1.61%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 748bf21...90f8029. Read the comment docs.

markComment: >
This pull request has been automatically marked as stale because it has not had
recent activity. It will be closed if no further activity occurs. You may re-open
it if you need more time. Thank you for your contributions.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contributions. sounds ironic here. I would either remove, or make it "warmer":

Suggested change
it if you need more time. Thank you for your contributions.
it if you need more time. We really appreciate your contribution and we are sorry that this hasn't been completed.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sgtm, but I would move this to the Close comment instead.

it if you need more time. Thank you for your contributions.
closeComment: >
This pull request has been automatically closed due to inactivity. You may re-open
it if you need more time. Thank you for your contributions.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
it if you need more time. Thank you for your contributions.
it if you need more time.

Signed-off-by: Yuri Shkuro <github@ysh.us>
Signed-off-by: Yuri Shkuro <github@ysh.us>
Signed-off-by: Yuri Shkuro <github@ysh.us>
jpkrohling
jpkrohling previously approved these changes Jan 20, 2021
@mergify mergify bot dismissed jpkrohling’s stale review January 20, 2021 14:55

Pull request has been modified.

@yurishkuro yurishkuro merged commit fe2a8ab into jaegertracing:master Jan 20, 2021
@yurishkuro yurishkuro deleted the fix-2717 branch January 20, 2021 16:08
@yurishkuro yurishkuro restored the fix-2717 branch January 20, 2021 16:08
@yurishkuro yurishkuro deleted the fix-2717 branch January 20, 2021 16:08
@yurishkuro yurishkuro restored the fix-2717 branch January 20, 2021 16:08
bhiravabhatla pushed a commit to bhiravabhatla/jaeger that referenced this pull request Jan 25, 2021
* Enable stale bot for PRs and questions

Signed-off-by: Yuri Shkuro <github@ysh.us>

* make it "warmer"

Signed-off-by: Yuri Shkuro <github@ysh.us>

* change stale label

Signed-off-by: Yuri Shkuro <github@ysh.us>

Co-authored-by: Juraci Paixão Kröhling <juraci@kroehling.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rethink stale bot integration
2 participants