Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to remove inactive maintainers; introduce Emeritus status #2733

Merged
merged 1 commit into from
Jan 19, 2021

Conversation

yurishkuro
Copy link
Member

@jaegertracing/jaeger-maintainers

@yurishkuro yurishkuro requested a review from a team as a code owner January 18, 2021 17:37
@codecov
Copy link

codecov bot commented Jan 18, 2021

Codecov Report

Merging #2733 (fa511a5) into master (4982b8e) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2733      +/-   ##
==========================================
+ Coverage   95.74%   95.76%   +0.02%     
==========================================
  Files         217      217              
  Lines        9628     9628              
==========================================
+ Hits         9218     9220       +2     
+ Misses        337      336       -1     
+ Partials       73       72       -1     
Impacted Files Coverage Δ
plugin/storage/badger/spanstore/reader.go 95.37% <0.00%> (-0.72%) ⬇️
cmd/query/app/static_handler.go 96.77% <0.00%> (+1.61%) ⬆️
cmd/query/app/server.go 90.16% <0.00%> (+1.63%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4982b8e...fa511a5. Read the comment docs.

@yurishkuro
Copy link
Member Author

This change is approved by the 2/3 majority (6 out of 8).

@yurishkuro yurishkuro merged commit 748bf21 into jaegertracing:master Jan 19, 2021
@yurishkuro yurishkuro deleted the maintainers branch January 19, 2021 20:25
bhiravabhatla pushed a commit to bhiravabhatla/jaeger that referenced this pull request Jan 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants