Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement metrics reader #3004

Merged
merged 8 commits into from
May 27, 2021

Conversation

albertteoh
Copy link
Contributor

Signed-off-by: Albert Teoh albert.teoh@logz.io

Which problem is this PR solving?

Short description of the changes

  • Implements GetLatencies, GetCallRates and GetErrorRates of the Prometheus MetricsReader.

Signed-off-by: Albert Teoh <albert.teoh@logz.io>
@albertteoh albertteoh requested a review from a team as a code owner May 17, 2021 12:12
@codecov
Copy link

codecov bot commented May 17, 2021

Codecov Report

Merging #3004 (9e80fa6) into master (23bbd63) will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3004      +/-   ##
==========================================
+ Coverage   95.94%   95.99%   +0.04%     
==========================================
  Files         224      225       +1     
  Lines        9773     9891     +118     
==========================================
+ Hits         9377     9495     +118     
  Misses        326      326              
  Partials       70       70              
Impacted Files Coverage Δ
...trics/prometheus/metricsstore/dbmodel/to_domain.go 100.00% <100.00%> (ø)
plugin/metrics/prometheus/metricsstore/reader.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23bbd63...9e80fa6. Read the comment docs.

@albertteoh
Copy link
Contributor Author

Friendly nudge on this, if anyone could take a look please; I'd like to move forward on this feature.

I'm cognisant that this PR is on the larger side as I wanted to provide more context for the reviewer; however, if the preference is to make this smaller, I could break it up into smaller PRs too.

The failing unit test is caused by a known flaky test issue, which I'm looking at now: #3025

Copy link
Contributor

@jpkrohling jpkrohling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had a question about the usage of sum(rate()), but other than that, looks good to me.

albertteoh added 5 commits May 26, 2021 17:06
Signed-off-by: albertteoh <albert.teoh@logz.io>
Signed-off-by: albertteoh <albert.teoh@logz.io>
Signed-off-by: albertteoh <albert.teoh@logz.io>
Signed-off-by: albertteoh <albert.teoh@logz.io>
@jpkrohling jpkrohling merged commit c0fb781 into jaegertracing:master May 27, 2021
@albertteoh albertteoh deleted the implement-metrics-reader branch May 27, 2021 12:31
@albertteoh
Copy link
Contributor Author

Thank you for the review, @jpkrohling!

@jpkrohling jpkrohling added this to the Release 1.23.0 milestone Jun 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants