Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cmux.ErrServerClosed #3029

Merged

Conversation

albertteoh
Copy link
Contributor

Signed-off-by: albertteoh albert.teoh@logz.io

Which problem is this PR solving?

Short description of the changes

  • Add expected cmux.ErrServerClosed error when connection is closed when waiting to Accept.

Signed-off-by: albertteoh <albert.teoh@logz.io>
@albertteoh albertteoh requested a review from a team as a code owner May 25, 2021 04:20
@albertteoh albertteoh requested a review from vprithvi May 25, 2021 04:20
@yurishkuro yurishkuro enabled auto-merge (squash) May 25, 2021 04:23
@yurishkuro
Copy link
Member

nice catch

@codecov
Copy link

codecov bot commented May 25, 2021

Codecov Report

Merging #3029 (fd3cf89) into master (f0d0518) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3029      +/-   ##
==========================================
+ Coverage   95.94%   95.96%   +0.02%     
==========================================
  Files         224      224              
  Lines        9773     9773              
==========================================
+ Hits         9377     9379       +2     
+ Misses        326      325       -1     
+ Partials       70       69       -1     
Impacted Files Coverage Δ
cmd/query/app/server.go 97.08% <100.00%> (-1.46%) ⬇️
plugin/storage/integration/integration.go 77.90% <0.00%> (+0.55%) ⬆️
cmd/query/app/static_handler.go 96.77% <0.00%> (+2.41%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7ef489...fd3cf89. Read the comment docs.

@yurishkuro yurishkuro merged commit 1170818 into jaegertracing:master May 25, 2021
@albertteoh albertteoh deleted the fix-flaky-TestServerGracefulExit branch May 25, 2021 04:59
@jpkrohling jpkrohling added this to the Release 1.23.0 milestone Jun 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flaky test TestServerGracefulExit
3 participants