Add Prometheus metrics reader factory and config #3049
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: albertteoh <albert.teoh@logz.io>
Codecov Report
@@ Coverage Diff @@
## master #3049 +/- ##
==========================================
+ Coverage 95.98% 96.03% +0.04%
==========================================
Files 225 229 +4
Lines 9891 9937 +46
==========================================
+ Hits 9494 9543 +49
+ Misses 327 325 -2
+ Partials 70 69 -1
Continue to review full report at Codecov.
|
14 tasks
jpkrohling
previously approved these changes
Jun 3, 2021
pkg/prometheus/config/config.go
Outdated
|
|
||
| import "time" | ||
|
|
||
| // Configuration describes the options to customize the storage behavior |
There was a problem hiding this comment.
Suggested change
| // Configuration describes the options to customize the storage behavior | |
| // Configuration describes the options to customize the storage behavior. |
plugin/metrics/factory.go
Outdated
| case prometheusStorageType: | ||
| return prometheus.NewFactory(), nil | ||
| } | ||
| return nil, fmt.Errorf("unknown metrics type %s. Valid types are %v", factoryType, AllStorageTypes) |
There was a problem hiding this comment.
Suggested change
| return nil, fmt.Errorf("unknown metrics type %s. Valid types are %v", factoryType, AllStorageTypes) | |
| return nil, fmt.Errorf("unknown metrics type %q. Valid types are %v", factoryType, AllStorageTypes) |
plugin/metrics/factory.go
Outdated
| func (f *Factory) CreateMetricsReader() (metricsstore.Reader, error) { | ||
| factory, ok := f.factories[f.MetricsStorageType] | ||
| if !ok { | ||
| return nil, fmt.Errorf("no %s backend registered for metrics store", f.MetricsStorageType) |
There was a problem hiding this comment.
Suggested change
| return nil, fmt.Errorf("no %s backend registered for metrics store", f.MetricsStorageType) | |
| return nil, fmt.Errorf("no %q backend registered for metrics store", f.MetricsStorageType) |
| ) | ||
|
|
||
| const ( | ||
| suffixHostPort = ".host-port" |
There was a problem hiding this comment.
Please, tell me that the next change is about adding TLS support to the communication with Prometheus :-)
There was a problem hiding this comment.
Ah yes, thanks :) I've added it to the checklist.
Signed-off-by: albertteoh <albert.teoh@logz.io>
jpkrohling
approved these changes
Jun 3, 2021
|
Thanks @jpkrohling! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Short description of the changes