Automatically detect OpenSearch version #3198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pavol Loffay <p.loffay@gmail.com>
|
@albertteoh would you like to review? |
Signed-off-by: Pavol Loffay <p.loffay@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #3198 +/- ##
=======================================
Coverage 95.93% 95.93%
=======================================
Files 239 239
Lines 14661 14661
=======================================
Hits 14065 14065
Misses 519 519
Partials 77 77
Continue to review full report at Codecov.
|
yurishkuro
previously approved these changes
Aug 10, 2021
|
Are the test failures expected? |
pavolloffay
commented
Aug 11, 2021
| @@ -68,6 +69,12 @@ func (s *ESStorageIntegration) getVersion() (uint, error) { | |||
| if err != nil { | |||
| return 0, err | |||
| } | |||
| // OpenSearch is based on ES 7.x | |||
| if strings.Contains(pingResult.TagLine, "OpenSearch") { | |||
There was a problem hiding this comment.
this is unfortunate we should refactor the test to use the pkg/es/config
no it needed a bit more love. It should be fixed now and it needs re-approval. |
|
still failed, I will have a look |
Signed-off-by: Pavol Loffay <p.loffay@gmail.com>
|
alright so the rollover script needed the "opensearch" logic as well. |
albertteoh
approved these changes
Aug 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates #3044