Add support for ciphersuites in tls config #3564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ashmita <ashmita.bohara@logz.io>
Codecov Report
@@ Coverage Diff @@
## main #3564 +/- ##
==========================================
- Coverage 96.49% 96.49% -0.01%
==========================================
Files 263 264 +1
Lines 15377 15402 +25
==========================================
+ Hits 14838 14862 +24
- Misses 456 457 +1
Partials 83 83
Continue to review full report at Codecov.
|
yurishkuro
reviewed
Mar 5, 2022
|
👋 Hello Yuri Thank you for the feedbacks. I tried to resolve them. It is ready for review again. |
yurishkuro
reviewed
Mar 5, 2022
albertteoh
pushed a commit
to albertteoh/jaeger
that referenced
this pull request
Jul 13, 2022
* Add support for ciphersuites in tls config Signed-off-by: Ashmita <ashmita.bohara@logz.io> * Feedbacks Signed-off-by: Ashmita152 <ashmita.bohara@logz.io> * Feedbacks Signed-off-by: Ashmita152 <ashmita.bohara@logz.io> * Feedbacks Signed-off-by: Ashmita152 <ashmita.bohara@logz.io> Signed-off-by: Albert Teoh <see.kwang.teoh@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ashmita ashmita.bohara@logz.io
Which problem is this PR solving?
Part of #3019
Short description of the changes
In golang's tls package, there are two kinds of ciphers: secure and insecure, we need to support both hence we are creating a map of all ciphers (mapping cipherName to cipherID)
I will raise min tls version support as separate pr.