Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add entries to env command for new storage types #3678

Merged
merged 5 commits into from May 16, 2022

Conversation

yurishkuro
Copy link
Member

We did not update this command when adding the adaptive sampling storage and metrics storage env vars.

@codecov
Copy link

codecov bot commented May 13, 2022

Codecov Report

Merging #3678 (eea38fb) into main (f3b4ac2) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #3678   +/-   ##
=======================================
  Coverage   96.57%   96.58%           
=======================================
  Files         268      268           
  Lines       15689    15715   +26     
=======================================
+ Hits        15152    15178   +26     
  Misses        447      447           
  Partials       90       90           
Impacted Files Coverage Δ
cmd/env/command.go 100.00% <100.00%> (ø)
plugin/storage/factory.go 98.39% <100.00%> (+1.20%) ⬆️
pkg/config/tlscfg/cert_watcher.go 92.63% <0.00%> (-2.11%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f3b4ac2...eea38fb. Read the comment docs.

@yurishkuro yurishkuro marked this pull request as ready for review May 13, 2022 16:20
@yurishkuro yurishkuro requested a review from a team as a code owner May 13, 2022 16:20
@yurishkuro
Copy link
Member Author

cc @joe-elliott @albertteoh

albertteoh
albertteoh previously approved these changes May 15, 2022
Copy link
Contributor

@albertteoh albertteoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

plugin/storage/factory.go Outdated Show resolved Hide resolved
Signed-off-by: Yuri Shkuro <github@ysh.us>
Signed-off-by: Yuri Shkuro <github@ysh.us>
Signed-off-by: Yuri Shkuro <github@ysh.us>
Signed-off-by: Yuri Shkuro <github@ysh.us>
Signed-off-by: Yuri Shkuro <github@ysh.us>
@yurishkuro yurishkuro merged commit 25558ac into jaegertracing:main May 16, 2022
@yurishkuro yurishkuro deleted the add-envs branch May 16, 2022 00:02
albertteoh pushed a commit to albertteoh/jaeger that referenced this pull request Jul 13, 2022
Signed-off-by: Albert Teoh <see.kwang.teoh@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants