Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable depguard linter on io/ioutil #3695

Merged
merged 1 commit into from
May 23, 2022
Merged

Enable depguard linter on io/ioutil #3695

merged 1 commit into from
May 23, 2022

Conversation

mmorel-35
Copy link
Contributor

Short description of the changes

Enable depguard on io/ioutil : It ensures that no io/ioutil package is used in the project and advise the developer to use the right packages.

Signed-off-by: Matthieu MOREL mmorel-35@users.noreply.github.com

Signed-off-by: Matthieu MOREL <mmorel-35@users.noreply.github.com>
@mmorel-35 mmorel-35 requested a review from a team as a code owner May 23, 2022 08:49
@codecov
Copy link

codecov bot commented May 23, 2022

Codecov Report

Merging #3695 (44ac03b) into main (f2c6bda) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #3695   +/-   ##
=======================================
  Coverage   97.34%   97.34%           
=======================================
  Files         268      268           
  Lines       15745    15745           
=======================================
  Hits        15327    15327           
  Misses        330      330           
  Partials       88       88           
Impacted Files Coverage Δ
cmd/query/app/static_handler.go 95.80% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f2c6bda...44ac03b. Read the comment docs.

@mmorel-35 mmorel-35 changed the title Enable depguard on io/ioutil Enable depguard linter on io/ioutil May 23, 2022
@yurishkuro yurishkuro merged commit f9992f7 into jaegertracing:main May 23, 2022
@mmorel-35 mmorel-35 deleted the depguard/io/ioutil branch May 23, 2022 12:15
albertteoh pushed a commit to albertteoh/jaeger that referenced this pull request Jul 13, 2022
Signed-off-by: Matthieu MOREL <mmorel-35@users.noreply.github.com>
Signed-off-by: Albert Teoh <see.kwang.teoh@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants