Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement gRPC storage plugin for metrics #4414

Closed

feat: Implement gRPC metrics plugin

61b0f86
Select commit
Loading
Failed to load commit list.
Closed

feat: implement gRPC storage plugin for metrics #4414

feat: Implement gRPC metrics plugin
61b0f86
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded May 23, 2023 in 1s

96.26% (target 95.00%)

View this Pull Request on Codecov

96.26% (target 95.00%)

Details

Codecov Report

Patch coverage: 32.12% and project coverage change: -0.80 ⚠️

Comparison is base (3021d31) 97.06% compared to head (61b0f86) 96.26%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4414      +/-   ##
==========================================
- Coverage   97.06%   96.26%   -0.80%     
==========================================
  Files         300      303       +3     
  Lines       17737    17955     +218     
==========================================
+ Hits        17217    17285      +68     
- Misses        417      558     +141     
- Partials      103      112       +9     
Impacted Files Coverage Δ
plugin/metrics/factory.go 88.63% <0.00%> (-11.37%) ⬇️
plugin/metrics/grpc/factory.go 0.00% <0.00%> (ø)
plugin/metrics/grpc/options.go 0.00% <0.00%> (ø)
plugin/storage/grpc/grpc.go 0.00% <0.00%> (ø)
plugin/storage/grpc/shared/metrics.go 0.00% <0.00%> (ø)
plugin/storage/grpc/shared/plugin.go 0.00% <0.00%> (ø)
plugin/storage/grpc/shared/grpc_client.go 84.91% <50.00%> (-0.80%) ⬇️
plugin/storage/grpc/shared/grpc_handler.go 74.11% <73.40%> (-0.36%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.