Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make OTLP receiver enabled by default #4494

Merged
merged 2 commits into from Jun 1, 2023

Conversation

yurishkuro
Copy link
Member

@yurishkuro yurishkuro commented May 31, 2023

This simplifies compatibility with OTEL/OTLP by not requiring to set the option to enable OTLP receiver. The option is still supported and allows OTLP receiver to be disabled when needed.

@yurishkuro yurishkuro requested a review from a team as a code owner May 31, 2023 15:55
Signed-off-by: Yuri Shkuro <github@ysh.us>
Signed-off-by: Yuri Shkuro <github@ysh.us>
@codecov
Copy link

codecov bot commented May 31, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.01 ⚠️

Comparison is base (756bc4e) 97.06% compared to head (47555e1) 97.05%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4494      +/-   ##
==========================================
- Coverage   97.06%   97.05%   -0.01%     
==========================================
  Files         300      300              
  Lines       17813    17813              
==========================================
- Hits        17290    17289       -1     
- Misses        419      420       +1     
  Partials      104      104              
Flag Coverage Δ
unittests 97.05% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cmd/collector/app/flags/flags.go 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@yurishkuro yurishkuro merged commit e2e257c into jaegertracing:main Jun 1, 2023
31 checks passed
@yurishkuro yurishkuro deleted the default-otlp-on branch June 1, 2023 04:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants