[test] Avoid logging to testing.T from server goroutine #4546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yuri Shkuro <github@ysh.us>
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #4546 +/- ##
==========================================
- Coverage 97.07% 97.04% -0.03%
==========================================
Files 301 301
Lines 17817 17817
==========================================
- Hits 17295 17291 -4
- Misses 419 422 +3
- Partials 103 104 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
kjschnei001
pushed a commit
to kjschnei001/jaeger
that referenced
this pull request
Jun 29, 2023
…g#4546) ## Which problem is this PR solving? - Resolves jaegertracing#4497 ## Short description of the changes - Do not use `zaptest.NewLogger(t)` because it causes race condition shown in the ticket when the server goroutine tries to log something that is being forwarded to `testing.T` while the test is being shutdown due to panic. - I was not able to get to the root cause why this happens, since the test is properly shutting down the server. This may indicate an issue in testing itself in how it handles panic. Signed-off-by: Yuri Shkuro <github@ysh.us> Signed-off-by: KevinSchneider <kevin.schneider@target.com>
afzal442
pushed a commit
to Cloud-Hacks/jaeger
that referenced
this pull request
Jul 10, 2023
…g#4546) ## Which problem is this PR solving? - Resolves jaegertracing#4497 ## Short description of the changes - Do not use `zaptest.NewLogger(t)` because it causes race condition shown in the ticket when the server goroutine tries to log something that is being forwarded to `testing.T` while the test is being shutdown due to panic. - I was not able to get to the root cause why this happens, since the test is properly shutting down the server. This may indicate an issue in testing itself in how it handles panic. Signed-off-by: Yuri Shkuro <github@ysh.us> Signed-off-by: Afzal Ansari <afzal442@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Short description of the changes
zaptest.NewLogger(t)because it causes race condition shown in the ticket when the server goroutine tries to log something that is being forwarded totesting.Twhile the test is being shutdown due to panic.