Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hotROD] Replace gRPC instrumentation with OTEL #4558



Copy link

@afzal442 afzal442 commented Jul 2, 2023

Which problem is this PR solving?

  • This PR refactors gRPC interceptors by downgrading opentracing APIs

Related to #3380
Part of #3381

Short description of the changes

  • Upgrades gRPC intrumentation to OTEL

@afzal442 afzal442 requested a review from a team as a code owner July 2, 2023 10:49
@afzal442 afzal442 requested a review from albertteoh July 2, 2023 10:49
Copy link

codecov bot commented Jul 2, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.02 ⚠️

Comparison is base (050ba81) 97.05% compared to head (e1fd5ae) 97.03%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4558      +/-   ##
- Coverage   97.05%   97.03%   -0.02%     
  Files         301      301              
  Lines       17837    17837              
- Hits        17312    17309       -3     
- Misses        421      423       +2     
- Partials      104      105       +1     
Flag Coverage Δ
unittests 97.03% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: Afzal Ansari <>
@afzal442 afzal442 force-pushed the driver-svr-otel-grpc-intrumn branch from 01ee503 to e1fd5ae Compare July 2, 2023 11:34
Copy link

@yurishkuro yurishkuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please write pr description

Copy link
Contributor Author

afzal442 commented Jul 2, 2023

Sorry @yurishkuro I was about to do that. Left it for review. I wrote the PR desc. 😄

@afzal442 afzal442 changed the title Refactors gRPC instrumentation [hotROD] Refactored gRPC instrumentation Jul 2, 2023
@yurishkuro yurishkuro changed the title [hotROD] Refactored gRPC instrumentation [hotROD] Replace gRPC instrumentation with OTEL Jul 2, 2023
@yurishkuro yurishkuro merged commit 321357a into jaegertracing:main Jul 2, 2023
31 checks passed
@afzal442 afzal442 deleted the driver-svr-otel-grpc-intrumn branch July 2, 2023 16:06
afzal442 added a commit to Cloud-Hacks/jaeger that referenced this pull request Jul 10, 2023
Signed-off-by: Afzal Ansari <>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants