Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add OTEL tracer to metricsstore reader component #4595

Merged
merged 13 commits into from Jul 29, 2023

Conversation

afzal442
Copy link
Contributor

@afzal442 afzal442 commented Jul 23, 2023

Which problem is this PR solving?

Short description of the changes

  • Replaces OT tracer with OTEL tracer to support jtracer pkg

Signed-off-by: Afzal Ansari <afzal442@gmail.com>
@afzal442 afzal442 requested a review from a team as a code owner July 23, 2023 06:51
@afzal442 afzal442 requested a review from vprithvi July 23, 2023 06:51
@codecov
Copy link

codecov bot commented Jul 23, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.02% ⚠️

Comparison is base (2c1bf07) 97.08% compared to head (2d298f3) 97.06%.
Report is 3 commits behind head on main.

❗ Current head 2d298f3 differs from pull request most recent head 7d4624b. Consider uploading reports for the commit 7d4624b to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4595      +/-   ##
==========================================
- Coverage   97.08%   97.06%   -0.02%     
==========================================
  Files         301      301              
  Lines       17857    17862       +5     
==========================================
+ Hits        17336    17338       +2     
- Misses        418      420       +2     
- Partials      103      104       +1     
Flag Coverage Δ
unittests 97.06% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
plugin/metrics/prometheus/factory.go 100.00% <100.00%> (ø)
plugin/metrics/prometheus/metricsstore/reader.go 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

plugin/metrics/prometheus/factory.go Outdated Show resolved Hide resolved
plugin/metrics/prometheus/metricsstore/reader.go Outdated Show resolved Hide resolved
plugin/metrics/prometheus/metricsstore/reader.go Outdated Show resolved Hide resolved
plugin/metrics/prometheus/metricsstore/reader.go Outdated Show resolved Hide resolved
plugin/metrics/prometheus/metricsstore/reader.go Outdated Show resolved Hide resolved
plugin/metrics/prometheus/metricsstore/reader_test.go Outdated Show resolved Hide resolved
Signed-off-by: Afzal Ansari <afzal442@gmail.com>
pkg/jtracer/jtracer.go Outdated Show resolved Hide resolved
Signed-off-by: Afzal Ansari <afzal442@gmail.com>
Signed-off-by: Afzal Ansari <afzal442@gmail.com>
Signed-off-by: Afzal Ansari <afzal442@gmail.com>
Signed-off-by: Afzal Ansari <afzal442@gmail.com>
Signed-off-by: Afzal Ansari <afzal442@gmail.com>
@afzal442 afzal442 changed the title [WIP] Add OTEL tracer to metrics reader component feat: Add OTEL tracer to metrics reader component Jul 26, 2023
@afzal442 afzal442 changed the title feat: Add OTEL tracer to metrics reader component feat: Add OTEL tracer to metricsstore reader component Jul 26, 2023
Signed-off-by: Afzal Ansari <afzal442@gmail.com>
Signed-off-by: Afzal Ansari <afzal442@gmail.com>
Signed-off-by: Afzal Ansari <afzal442@gmail.com>
Signed-off-by: Afzal Ansari <afzal442@gmail.com>
@afzal442 afzal442 requested a review from yurishkuro July 28, 2023 15:14
Signed-off-by: Afzal Ansari <afzal442@gmail.com>
@afzal442 afzal442 force-pushed the replace-with-otel-tp branch 2 times, most recently from 1e647a3 to 6fdb455 Compare July 28, 2023 19:18
Signed-off-by: Afzal Ansari <afzal442@gmail.com>
@yurishkuro yurishkuro merged commit 287562c into jaegertracing:main Jul 29, 2023
31 checks passed
@afzalbin64 afzalbin64 deleted the replace-with-otel-tp branch July 29, 2023 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants